Skip to content

Commit

Permalink
Merge pull request #48 from Barre/sign_apple
Browse files Browse the repository at this point in the history
Implement notarization on desktop apple binaries.
  • Loading branch information
Barre authored Jan 3, 2023
2 parents 9461833 + f13dd7d commit d163d84
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 1 deletion.
16 changes: 16 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,16 @@ jobs:
name: Install rust apple arm target
run: rustup target add aarch64-apple-darwin

- if: startsWith(matrix.os, 'macos') == true
name: Install apple api key private key
run: |
mkdir -p ~/private_keys
echo "$API_KEY" >> ~/private_keys/AuthKey_"$API_KEY_ID".p8
shell: bash
env:
API_KEY: ${{secrets.APPLE_API_KEY_CONTENTS}}
API_KEY_ID: ${{secrets.APPLE_API_KEY}}

- name: Install node packages
working-directory: ./web_frontend
run: npm i
Expand All @@ -238,6 +248,12 @@ jobs:
uses: tauri-apps/tauri-action@5a6072a9edbbf71718caee364b5b96731d7580fc #v0 does not handle universal builds
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ENABLE_CODE_SIGNING: ${{ secrets.APPLE_CERTIFICATE }}
APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }}
APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
APPLE_SIGNING_IDENTITY: ${{ secrets.APPLE_SIGNING_IDENTITY }}
APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }}
APPLE_API_KEY: ${{ secrets.APPLE_API_KEY }}
with:
tagName: privaxy-v__VERSION__ # the action automatically replaces \_\_VERSION\_\_ with the app version
releaseName: 'Privaxy v__VERSION__'
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v0.5.1

- Apple build of desktop app is now notarized.

## v0.5.0

- Add builds for apple silicon
Expand Down
4 changes: 4 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ lto = true
codegen-units = 1
opt-level = 3

[profile.release.package.privaxy_app]
codegen-units = 1
opt-level = 3

[profile.release.package.web_frontend]
codegen-units = 1
opt-level = 's'
2 changes: 1 addition & 1 deletion src-tauri/tauri.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
},
"package": {
"productName": "Privaxy",
"version": "0.5.0"
"version": "0.5.1"
},
"tauri": {
"allowlist": {
Expand Down

0 comments on commit d163d84

Please sign in to comment.