add some missing tests

Barsonax · Apr 28, 2024 · dbbd221 · dbbd221
1 parent 18126d7
commit dbbd221
Show file tree

Hide file tree

Showing 7 changed files with 61 additions and 26 deletions.
diff --git a/CleanAspCore.Api.Tests/Features/Employees/CreateEmployeeTests.cs b/CleanAspCore.Api.Tests/Features/Employees/CreateEmployeeTests.cs
@@ -27,4 +27,29 @@ public async Task CreateEmployee_IsAdded()
             context.Employees.Should().BeEquivalentTo(new[] { new { Id = createdId } });
         });
     }
+
+    [Test]
+    public async Task CreateEmployee_InvalidRequest_ReturnsBadRequest()
+    {
+        //Arrange
+        var createEmployeeRequest = new CreateEmployeeRequestFaker()
+            .RuleFor(x => x.FirstName, string.Empty)
+            .Generate();
+
+        Sut.SeedData(context =>
+        {
+            context.Departments.Add(new DepartmentFaker().RuleFor(x => x.Id, createEmployeeRequest.DepartmentId).Generate());
+            context.Jobs.Add(new JobFaker().RuleFor(x => x.Id, createEmployeeRequest.JobId).Generate());
+        });
+
+        //Act
+        var response = await Sut.CreateClientFor<IEmployeeApiClient>().CreateEmployee(createEmployeeRequest);
+
+        //Assert
+        await response.AssertStatusCode(HttpStatusCode.BadRequest);
+        Sut.AssertDatabase(context =>
+        {
+            context.Employees.Should().BeEmpty();
+        });
+    }
 }
diff --git a/CleanAspCore.Api.Tests/Features/Employees/DeleteEmployeeByIdTests.cs b/CleanAspCore.Api.Tests/Features/Employees/DeleteEmployeeByIdTests.cs
@@ -22,4 +22,17 @@ public async Task DeleteEmployeeById_IsDeleted()
         await response.AssertStatusCode(HttpStatusCode.OK);
         Sut.AssertDatabase(context => { context.Employees.Should().BeEmpty(); });
     }
+
+    [Test]
+    public async Task DeleteEmployeeById_DoesNotExist_ReturnsNotFound()
+    {
+        //Arrange
+        var id = Guid.NewGuid();
+
+        //Act
+        var response = await Sut.CreateClientFor<IEmployeeApiClient>().DeleteEmployeeById(id);
+
+        //Assert
+        await response.AssertStatusCode(HttpStatusCode.NotFound);
+    }
 }
diff --git a/CleanAspCore.Api.Tests/Features/Employees/UpdateEmployeeByIdTests.cs b/CleanAspCore.Api.Tests/Features/Employees/UpdateEmployeeByIdTests.cs
@@ -35,4 +35,22 @@ public async Task UpdateEmployeeById_IsUpdated()
             });
         });
     }
+
+    [Test]
+    public async Task UpdateEmployeeById_DoesNotExist_ReturnsNotFound()
+    {
+        //Arrange
+        var employee = new EmployeeFaker().Generate();
+
+        UpdateEmployeeRequest updateEmployeeRequest = new()
+        {
+            FirstName = "Updated"
+        };
+
+        //Act
+        var response = await Sut.CreateClientFor<IEmployeeApiClient>().UpdateEmployeeById(employee.Id, updateEmployeeRequest);
+
+        //Assert
+        await response.AssertStatusCode(HttpStatusCode.NotFound);
+    }
 }
diff --git a/CleanAspCore/Features/Employees/Endpoints/UpdateEmployeeById.cs b/CleanAspCore/Features/Employees/Endpoints/UpdateEmployeeById.cs
@@ -19,16 +19,9 @@ public sealed class UpdateEmployeeRequest
 
 internal static class UpdateEmployeeById
 {
-    internal static async Task<Results<NoContent, NotFound, ValidationProblem>> Handle(Guid id,
-        [FromBody] UpdateEmployeeRequest updateEmployeeRequest, HrContext context, [FromServices] IValidator<UpdateEmployeeRequest> validator, CancellationToken cancellationToken)
+    internal static async Task<Results<NoContent, NotFound, ValidationProblem>> Handle(
+        Guid id, [FromBody] UpdateEmployeeRequest updateEmployeeRequest, HrContext context, CancellationToken cancellationToken)
     {
-        var validationResult = await validator.ValidateAsync(updateEmployeeRequest, cancellationToken);
-
-        if (!validationResult.IsValid)
-        {
-            return TypedResults.ValidationProblem(validationResult.ToDictionary());
-        }
-
         var builder = new SetPropertyBuilder<Employee>()
             .SetPropertyIfNotNull(x => x.FirstName, updateEmployeeRequest.FirstName)
             .SetPropertyIfNotNull(x => x.LastName, updateEmployeeRequest.LastName)

diff --git a/CleanAspCore/Features/Employees/IEmployeeApiClient.cs b/CleanAspCore/Features/Employees/IEmployeeApiClient.cs
@@ -11,7 +11,7 @@ public interface IEmployeeApiClient
     [Post("/employees")]
     Task<HttpResponseMessage> CreateEmployee(CreateEmployeeRequest createEmployeeRequest);
 
-    [Put("/employees/{id}")]
+    [Patch("/employees/{id}")]
     Task<HttpResponseMessage> UpdateEmployeeById(Guid id, UpdateEmployeeRequest updateEmployeeRequest);
 
     [Delete("/employees/{id}")]

diff --git a/CleanAspCore/Features/Employees/Routes.cs b/CleanAspCore/Features/Employees/Routes.cs
@@ -19,6 +19,7 @@ internal static void AddEmployeesRoutes(this IEndpointRouteBuilder host)
 
         employeeGroup.MapDelete("/{id:guid}", DeleteEmployeeById.Handle);
 
-        employeeGroup.MapPut("/{id:guid}", UpdateEmployeeById.Handle);
+        employeeGroup.MapPatch("/{id:guid}", UpdateEmployeeById.Handle)
+            .WithRequestValidation<UpdateEmployeeRequest>();;
     }
 }
diff --git a/CleanAspCore/Features/Import/EmployeeFaker.cs b/CleanAspCore/Features/Import/EmployeeFaker.cs
@@ -24,18 +24,3 @@ public EmployeeFaker()
         });
     }
 }
-
-public sealed class EmployeeDtoFaker : Faker<EmployeeDto>
-{
-    public EmployeeDtoFaker()
-    {
-        UseSeed(3);
-        RuleFor(x => x.FirstName, f => f.Name.FirstName());
-        RuleFor(x => x.LastName, f => f.Name.LastName());
-        RuleFor(x => x.Email, f => f.Internet.Email());
-        RuleFor(x => x.Gender, f => f.PickRandom("Male", "Female"));
-        RuleFor(x => x.DepartmentId, f => f.Random.Guid());
-        RuleFor(x => x.JobId, f => f.Random.Guid());
-
-    }
-}