Merge Network version 13 into develop #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ravel-model-two-networks into network-version13
ShSt now requires at least 12.0.0.
- INPUT_DATA_DIR and OUTPUT_DATA_DIR environment variables - renamed input file to be more clear as to the source - clearer variable names (not i,g) - update README accordingly
Relating to generating the files on a local drive that is not the C drive (which requires mounting it as a volume in docker) Also adding more detail to readme
So we can look at this easily!
- INPUT_DATA_DIR and OUTPUT_DATA_DIR environment variables - clearer variable names (not i,g) - update README accordingly
- the network is huge so try to optimize memory usage - rename output directory to be more consistent with step1 - output geopackage so for easy GIS viewing - output geojson directly from geodataframe to explore the difference between this version and what was output before
…ravel-model-two-networks into network-version13
with additional documentation and fewer groupby()/sort() operations. This is functionally equivalent to the previous version with the exception that since the aggregation isn't performed on rows which don't have duplicate indices, so rows with u==v now don't have their last node removed from the nodeIds list column (previously they did).
- modify length-based aggregation to ensure all aggregated links have non-null value in shst attributes - removed "index" column from upstream - added more documentation on "no_aggregation_grouped" with waySections_len > 1 - minor cosmetic changes
And add ACE to rail_gtfs, fix args in to_feather()
The downstream error: when loading the geopackage layer into ArcGIS Pro, it cannot load the data table or do data query due to 'Failed to create a page cursor'.
…ravel-model-two-networks into network-version13
1) drop interim fields created during lane accounting one the imputation is done 2) when aggregate_osm_ways_back_to_shst_links, include raw osm lane/turn tags in length-based aggregation
… model network Note: customized to the data schema of tm2_marin model network and tm2_nonMarin model network. If to be applied to other model network data, need to check the data schema first.
…e shst matching - for tm2_marin and tm2_nonMarin, uses methods.merge_legacy_tm2_network_hov_links_with_gp() - for CCTA and ACTC, drop hov/nontruck links for now; potential TODO is to run shst match on them separately
- revise the "merge_legacy_tm2_network_hov_links_with_gp" method - remove sfcta HOV links before shst matching (because they don't match well, and only a handful of links are affected)
- move PEMS conflation out of third-party-conflation - fix the bug in PEMS conflation method - add more notes around de-duplicating links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals of network v13 pre-project card (pipeline) development (asana task)