Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/django 4 compatibility #12

Open
wants to merge 55 commits into
base: master
Choose a base branch
from

Conversation

Vimdar
Copy link

@Vimdar Vimdar commented Apr 27, 2022

No description provided.

atereshkin and others added 30 commits April 3, 2018 12:40
Fix user model in backend.py - proper get_user_model()
Removed demo() view & url
Added rlp==0.6.0 to install_requires (crashes with rlp>=1.0)
Added Bearle to MIT license
Moved ethereum_address retrieval from views to POST-only
Added templateview with login.html
Aded django, packaging to requirements
Added eth_utils to package requirements (setup.py), requirements.txt
Added example/db.sqlite3 to gitignore
Started autologin in js
Made backend inherit from backends.ModelBackend
Fixed LoginForm to do form-only work (data validation)
Made SignupForm use arbitrary fields
Added login_api to urls (temporarily)
Added login_api view (working)
Moved all the settings to settings.py (from web3auth.settings import app_settings
Fixed SignupForm in forms - added clean_address_field, made email required if present
Addded redirect_url to successful login_api call, fixed form.errors.as_json()
Made signup_api view
Added temporary signup_api url
Added login, auto_login template views to urls
Added working login, autologin to example templates
Deleted old js, added callbacks in web3auth.js
Removed templates in pkg, replaced with base
Added couple of things to readme to explain to user
Used login_url param in html
Forced address field required too in Signup form
Added unique reminder in the readme
Added sphinx to requirements_dev
Fixed base.html in example
Added redirect view to login in example urls, added url names
Made docs buildable (inserted fix in docs/conf.py)
Added docstring to signup_view
Added initial author to AUTHORS.rst
Travis happy
@delneg
Copy link

delneg commented Apr 27, 2022

Hello, and thanks for making this PR.
It's good when people try to fix the problem themselves & share it with the community.
Anyway, it's a big PR and we haven't touched the project for a while.
It may take some time to do a comprehensive review, but I'm sure that we'll merge it soon.
It could help if you could add some tests, and probably github workflow to have it auto-tested (an example can be seen here https://github.com/Bearle/django_private_chat2/blob/master/.github/workflows/test.yml), that would make the task of verifying the code in this PR easier.
If that's too much to ask for, that's alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants