-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate existing code #4
base: main
Are you sure you want to change the base?
Conversation
Add workflow to a working branch
Updated workflow
Test_Run_for_PR_#4_(17)_Bemby.AccountModule.ApiRun Summary
Overall Result: ✔️ Pass
Result SetsRun MessagesInformational
Warning
Error
|
Test_Run_for_PR_#4_(17)_Bemby.AccountModule.ApplicationRun Summary
Overall Result: ✔️ Pass
Result SetsBemby.AccountModule.Application.Tests.dll - 100%Full Results
Run MessagesInformational
Warning
Error
|
Test_Run_for_PR_#4_(17)_Bemby.AccountModule.Application.InterfacesRun Summary
Overall Result: ✔️ Pass
Result SetsRun MessagesInformational
Warning
Error
|
Test_Run_for_PR_#4_(17)_Bemby.AccountModule.DomainRun Summary
Overall Result: ✔️ Pass
Result SetsRun MessagesInformational
Warning
Error
|
Test_Run_for_PR_#4_(17)_Bemby.AccountModule.InfrastructureRun Summary
Overall Result: ✔️ Pass
Result SetsBemby.AccountModule.Infrastructure.Tests.dll - 100%Full Results
Run MessagesInformational
Warning
Error
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good the only change I would say needs to happen is the mail stuff in the create method of the account service.
src/Bemby.AccountModule.Application.Interfaces/Services/IEmailService.cs
Outdated
Show resolved
Hide resolved
…Nytte. Made suggested changes from PR comments. Started adding in the Nytte email package.
…a point to build and send emails using razor; Nytte.Email's interface needs tidying.
Modified script to pull in the submodules so it will build.
Test_Run_for_PR_#4_(20)_Bemby.AccountModule.ApiRun Summary
Overall Result: ✔️ Pass
Result SetsRun MessagesInformational
Warning
Error
|
Test_Run_for_PR_#4_(20)_Bemby.AccountModule.ApplicationRun Summary
Overall Result: ✔️ Pass
Result SetsBemby.AccountModule.Application.Tests.dll - 100%Full Results
Run MessagesInformational
Warning
Error
|
Test_Run_for_PR_#4_(20)_Bemby.AccountModule.Application.InterfacesRun Summary
Overall Result: ✔️ Pass
Result SetsRun MessagesInformational
Warning
Error
|
Test_Run_for_PR_#4_(20)_Bemby.AccountModule.DomainRun Summary
Overall Result: ✔️ Pass
Result SetsRun MessagesInformational
Warning
Error
|
Test_Run_for_PR_#4_(20)_Bemby.AccountModule.InfrastructureRun Summary
Overall Result: ✔️ Pass
Result SetsBemby.AccountModule.Infrastructure.Tests.dll - 100%Full Results
Run MessagesInformational
Warning
Error
|
Closes #2
Closes #1