forked from oneapi-src/unified-runtime
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXP][Command-Buffer] Optimize L0 command-buffer submission #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancepillois
requested review from
EwanC,
ori-sky,
reble,
Bensuo and
julianmi
February 23, 2024 16:45
EwanC
reviewed
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nitpicks but looking good.
DPC++ linked PR : reble/llvm#358 |
mfrancepillois
changed the title
[EXP][Command-Buffer] Support for use of In-order command-list
[EXP][Command-Buffer] Optimize L0 command-buffer submission
Feb 27, 2024
julianmi
reviewed
Feb 28, 2024
EwanC
approved these changes
Feb 29, 2024
Bensuo
approved these changes
Mar 5, 2024
Upstream PR opened here: oneapi-src#1442 Closing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for use of in-order command-list for linear graph.
If the command-buffer is created with in-order command-list flag, an in-order command-list is created and the commands are enqueued without synchronization events.
Add an
enableProfiling
propery.If this property is not set, the profiling capability of events attached to the commands of the command-buffer is disabled.
The
EventCreate
function signature has been modified to allow us to create an event with the profiling capability disabled even if the event is created without a queue.Remove map copy in
getEventsFromSyncPoints
to reduce the finalization delay