Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXP][Command-Buffer] Optimize L0 command-buffer submission #9

Closed
wants to merge 13 commits into from

Conversation

mfrancepillois
Copy link

@mfrancepillois mfrancepillois commented Feb 23, 2024

  • Add support for use of in-order command-list for linear graph.
    If the command-buffer is created with in-order command-list flag, an in-order command-list is created and the commands are enqueued without synchronization events.

  • Add an enableProfiling propery.
    If this property is not set, the profiling capability of events attached to the commands of the command-buffer is disabled.
    The EventCreate function signature has been modified to allow us to create an event with the profiling capability disabled even if the event is created without a queue.

  • Remove map copy in getEventsFromSyncPoints to reduce the finalization delay

Copy link
Collaborator

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks but looking good.

source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.hpp Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
@mfrancepillois
Copy link
Author

DPC++ linked PR : reble/llvm#358

@mfrancepillois mfrancepillois marked this pull request as ready for review February 26, 2024 17:34
@mfrancepillois mfrancepillois changed the title [EXP][Command-Buffer] Support for use of In-order command-list [EXP][Command-Buffer] Optimize L0 command-buffer submission Feb 27, 2024
scripts/core/exp-command-buffer.yml Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
@Bensuo
Copy link
Owner

Bensuo commented Mar 21, 2024

Upstream PR opened here: oneapi-src#1442

Closing this now.

@Bensuo Bensuo closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants