feat: prioritize api_key over tenant_id for more Azure AD token provider #8318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
you-n-g
changed the title
| @@ -195,7 +195,8 @@ def set_client( # noqa: PLR0915 | |||
| organization = get_secret_str(organization_env_name) | |||
| litellm_params["organization"] = organization | |||
| azure_ad_token_provider: Optional[Callable[[], str]] = None | |||
| if litellm_params.get("tenant_id"): | |||
| # If we have api_key, then we have higher priority | |||
| if not api_key and litellm_params.get("tenant_id"): | |||
There was a problem hiding this comment.
this logic is getting quite complicated, can we please refactor into a smaller function and add testing for this
There was a problem hiding this comment.
Which section are you referring to (from which line to which line)?
Hi ,@krrishdholakia
this logic is getting quite complicated, can we please refactor into a smaller function and add testing for this
There was a problem hiding this comment.
What kind of test is expected? Do we any example that I can refer to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prioritize api_key over tenant_id for more Azure AD token provider
Relevant issues
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes
[REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes