-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cohere v2/rerank support #8421
Open
vibhavbhat
wants to merge
8
commits into
BerriAI:main
Choose a base branch
from
vibhavbhat:vib/cohere-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
61e8eee
Support v2 endpoint cohere rerank
vibhavbhat 842e296
Add tests and docs
vibhavbhat 96b2384
Make v1 default if old params used
vibhavbhat 50e0ff1
Update docs
vibhavbhat 9c51aee
Update docs pt 2
vibhavbhat dc54acd
Update tests
vibhavbhat dd0b56e
Add e2e test
vibhavbhat d0fdf10
Clean up code
vibhavbhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,6 +83,7 @@ def rerank( # noqa: PLR0915 | |
rank_fields: Optional[List[str]] = None, | ||
return_documents: Optional[bool] = True, | ||
max_chunks_per_doc: Optional[int] = None, | ||
max_tokens_per_doc: Optional[int] = None, | ||
**kwargs, | ||
) -> Union[RerankResponse, Coroutine[Any, Any, RerankResponse]]: | ||
""" | ||
|
@@ -99,6 +100,9 @@ def rerank( # noqa: PLR0915 | |
try: | ||
_is_async = kwargs.pop("arerank", False) is True | ||
optional_params = GenericLiteLLMParams(**kwargs) | ||
# Params that are unique to specific versions of the client for the rerank call | ||
unique_version_params = {"max_chunks_per_doc": max_chunks_per_doc, "max_tokens_per_doc": max_tokens_per_doc} | ||
present_version_params = [k for k, v in unique_version_params.items() if v is not None] | ||
|
||
model, _custom_llm_provider, dynamic_api_key, dynamic_api_base = ( | ||
litellm.get_llm_provider( | ||
|
@@ -113,6 +117,8 @@ def rerank( # noqa: PLR0915 | |
ProviderConfigManager.get_provider_rerank_config( | ||
model=model, | ||
provider=litellm.LlmProviders(_custom_llm_provider), | ||
api_base=optional_params.api_base, | ||
present_version_params=present_version_params | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we avoid adding these two new params to |
||
) | ||
) | ||
|
||
|
@@ -127,6 +133,7 @@ def rerank( # noqa: PLR0915 | |
rank_fields=rank_fields, | ||
return_documents=return_documents, | ||
max_chunks_per_doc=max_chunks_per_doc, | ||
max_tokens_per_doc=max_tokens_per_doc, | ||
non_default_params=kwargs, | ||
) | ||
|
||
|
@@ -173,6 +180,7 @@ def rerank( # noqa: PLR0915 | |
response = base_llm_http_handler.rerank( | ||
model=model, | ||
custom_llm_provider=_custom_llm_provider, | ||
provider_config=rerank_provider_config, | ||
optional_rerank_params=optional_rerank_params, | ||
logging_obj=litellm_logging_obj, | ||
timeout=optional_params.timeout, | ||
|
@@ -194,6 +202,7 @@ def rerank( # noqa: PLR0915 | |
model=model, | ||
custom_llm_provider=_custom_llm_provider, | ||
optional_rerank_params=optional_rerank_params, | ||
provider_config=rerank_provider_config, | ||
logging_obj=litellm_logging_obj, | ||
timeout=optional_params.timeout, | ||
api_key=dynamic_api_key or optional_params.api_key, | ||
|
@@ -222,6 +231,7 @@ def rerank( # noqa: PLR0915 | |
response = base_llm_http_handler.rerank( | ||
model=model, | ||
custom_llm_provider=_custom_llm_provider, | ||
provider_config=rerank_provider_config, | ||
optional_rerank_params=optional_rerank_params, | ||
logging_obj=litellm_logging_obj, | ||
timeout=optional_params.timeout, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request, instead of adding complexity to /rerank. Create rerankv2/transformation.py. It should inherit from CohereRerankConfig
This is an established pattern we follow. See