Completed 2 way communication for slack #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@CodiumAI-Agent /review |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
chinmoy12c
requested changes
Mar 13, 2024
| @@ -0,0 +1,3 @@ | |||
| export type SlackBotProviderConfig = { | |||
| botToken: string | |||
| }; | |||
| @@ -21,4 +21,4 @@ test('should trigger Slack correctly', async () => { | |||
| webhookUrl: 'webhookUrl', | |||
| content: 'chat message', | |||
| }); | |||
| }); | |||
| }); | |||
| userID: msg.user, | ||
| bot: false, | ||
| }, | ||
| channelURI: "Bot", |
There was a problem hiding this comment.
Suggested change
| channelURI: "Bot", | |
| channelURI: "Slack", |
| text: string; // The text of the message | ||
| ts: string; // The timestamp of the message | ||
| channel: string; // The ID of the channel where the message was sent | ||
| }; |
Comment on lines
21
to
23
| webhookUrl: 'webhookUrl', | ||
| content: 'chat message', | ||
| }); |
There was a problem hiding this comment.
Not sure if this test is correct. The sendMessage method expects channel to be present, but this test checks for webhookUrl and chat message.
| return { | ||
| id: response.headers['x-slack-req-id'], | ||
| date: new Date().toISOString(), | ||
| async convertMessageToXMsg(msg: SlackUpdateMessage): Promise<XMessage> { |
There was a problem hiding this comment.
can we have a test for this function as well?
|
Hey @NarayanaSabari you would also need to add this adapter to the factory. Refer to the documentation here for details. |
|
Hey @chinmoy12c, Due to some bug in GitHub, my latest commit is not showing in this PR, so I am closing this pr and raising a new PR. |
|
This is the updated PR : #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xmessage for 2 way communication on Slack is created, here is the raised Issue : samagra-comms/adapter#60