This repository has been archived by the owner on Apr 20, 2019. It is now read-only.
Convert worldguard regions to grief prevention regions #64
This pull request is big! We’re only showing the most recent 250 commits.
Commits on Aug 31, 2020
Commits on Sep 7, 2020
-
-
Add several hostile non-monsters (#927)
* Add a couple of new/missed hostile cases * "Zoo" friendliness * Prevent food attack vector for neutral animals
-
-
-
Commits on Sep 10, 2020
Commits on Sep 14, 2020
Commits on Sep 15, 2020
Commits on Sep 19, 2020
Commits on Sep 20, 2020
Commits on Sep 26, 2020
Commits on Oct 2, 2020
Commits on Oct 3, 2020
Commits on Oct 4, 2020
Commits on Oct 6, 2020
Commits on Oct 7, 2020
Commits on Oct 9, 2020
Commits on Oct 12, 2020
Commits on Oct 17, 2020
Commits on Oct 24, 2020
-
Make placing and breaking boats use containertrust (#1065)
Consistent with minecarts
-
Commits on Oct 29, 2020
-
Fix incorrect retract check and everywhere modes checking subclaim (#…
…1083) * Retraction checked block behind piston when no blocks were moved * Everywhere modes are supposed to ignore subclaims, so piston claim should not be a subclaim
Commits on Nov 5, 2020
Commits on Nov 15, 2020
Commits on Nov 18, 2020
Commits on Nov 29, 2020
Commits on Dec 8, 2020
Commits on Dec 9, 2020
Commits on Dec 11, 2020
Commits on Dec 12, 2020
Commits on Dec 14, 2020
-
-
remove release drafter for now
Will experiment more on another repo later
-
-
-
Make POM more explicit about plugin versions (#1153)
- Add missing POM sections: name, description, inceptionYear, packaging, licenses, and issueManagement - For tests, use junit-jupiter instead of both junit-jupiter-api and junit-jupiter-engine - Dependency versions: - junit-jupiter 5.6.2 -> 5.7.0 - git-commit-id-plugin 3.0.0 -> 4.0.3 - Explicitly use the latest plugin versions, rather than the dated default versions from the Super POM - Define Java language source- and target level directly in the maven-compiler-plugin configuration
Commits on Dec 16, 2020
-
Add waterlogging check for buckets (#1156)
Co-authored-by: Adam <[email protected]>
Commits on Dec 17, 2020
Commits on Dec 18, 2020
Commits on Dec 19, 2020
Commits on Jan 9, 2021
Commits on Jan 13, 2021
Commits on Jan 19, 2021
Commits on Jan 24, 2021
-
use git describe variable for version
I wish there was an inverse of describe-short, i.e. only includes the count + commit hash
Commits on Feb 19, 2021
Commits on Apr 8, 2021
Commits on Apr 29, 2021
Commits on May 29, 2021
-
Prevent nametag usage unless player can kill target (#1337)
Addresses discussion #1333
Commits on Jun 5, 2021
-
Include scope in dependency information (#1390)
Ideally will reduce the number of people shading GP into their projects by mistake.
Commits on Jun 17, 2021
Commits on Jun 19, 2021
Commits on Jun 24, 2021
-
Add ClaimPermissionCheckEvent (#1006)
Also contains a bit of refactoring on internal logic. Modifies (secondary) siege mechanics. * Un-couple siege from core claim functions * UUID overload, documentation, naming clarity * Add internal special message override support * Fix permission calculation issues in subclaims * Migrate egg handling to new methods * Use suppliers for denial message In many use cases addons don't care why a denial occurred, only that it did. On-demand calculation is vastly preferable to reduce server impact.
Commits on Jul 10, 2021
-
* Update to include 1.17 materials and tags * Use world height for claim max height * Account for worlds with min height < 0 Fix restore not working under y 0 Change default max claim depth to integer min value Fix creative claims always going to 0, not world min height * Update material listings to include new blocks * Fixes a few missed cases from previous versions * Replaced claim to bounding box bandaid for world max height increase with actual world limit * Account for worlds with min height less than zero * New default maximum depth is now integer min value (-2147483648) to not restrict users no matter how weirdly they set up worlds * Creative claims always extend to world min height, not 0 * RestoreNature restores to a max depth of world min height instead of 0 Closes #1309 Closes #1431
Commits on Jul 21, 2021
-
Config option on silencing ban messages (#1480)
Enabled by default as per previous behavior.
Commits on Jul 31, 2021
Commits on Aug 2, 2021
Commits on Aug 8, 2021
Commits on Aug 19, 2021
Commits on Sep 12, 2021
Commits on Oct 25, 2021
-
Fix some issues with splash potions (#1636)
- Fix NPE on non-player thrower - Fix non-player thrower warning console when blocked - Fix only first entity being saved - Allow dispensers inside the same claim to harm entities with potions (consistent with arrows) - Fix spamming player on multi-hit/multi-effect
Commits on Oct 27, 2021
Commits on Dec 5, 2021
-
Update Java and fix AppVeyor (#1663)
* Update Java and fix AppVeyor Target Java 16 Run CI using Java 17 Use provided Maven installation instead of relying on mirror link Remove Java 7 memory limitation settings * Fix Jitpack build for Java > 8 Jitpack uses Java 8 by default. While their (very minimal) explanation of settings suggests specifying `jdk: [ openjdk17 ]` would be enough, it does not appear to work. Not sure if that's just an issue with their image not including JDK17 yet or something, but this does function.
-
-
Don't fire EntityDamageByEntityEvent when renaming (#1680)
Fixes incompatibility with mcMMO's health bar displays
Commits on Dec 14, 2021
Commits on Jan 5, 2022
Commits on Feb 28, 2022
-
-
Fix incorrect permission bypass for Edit ClaimPermission (#1772)
Also adds nullity annotations to claim permission methods Fixes #1769
-
-
Commits on Mar 1, 2022
Commits on Apr 1, 2022
Commits on May 25, 2022
-
-
Stop people creating nether portals in claimed land (#1842)
config option PreventNonPlayerCreatedPortals
Commits on Jul 22, 2022
Commits on Jul 23, 2022
Commits on Feb 28, 2023
Commits on Mar 9, 2023
-
Reload messages on /gpreload (#1266)
* Reload messages on /gpreload * Reset regex pattern on reload * Protected, formatting fixes
-
Commits on Mar 11, 2023
Commits on Apr 9, 2023
Commits on Jun 18, 2023
-
Add CommandHelper to softdepend (#2043)
GriefPrevention was unable to load claims because it was loading before CommandHelper (world management plugin)
Commits on Jun 19, 2023
-
Major cleanup/refactor of entity damage handling (#2040)
* Extract damage handling to EntityDamageHandler * Remove unreachable firework handling Fireworks have become real projectiles and now actually have a shooter. * Extract handler for pet damage by environment * Rename previously extracted handler for consistency * Extract handler for PVP damage by lingering potions * Extract handler for PVP damage by players * Extract handler for PVP damage by pets * Extract handler for damage requiring build trust by entities * Extract handler for damage to creatures by entities * Clean up isMonster Switched to instanceof with pattern variables instead of educated guess casting. Previously we've run into issues with custom pet plugins creating NMS-based entities that return an "incorrect" EntityType for the Bukkit interfaces they implement. The instanceof calls are marginally slower, but are much safer for the subsequent checks. * Clean up handlePetDamageByEnvironment Use quick returns, pattern variable, and new switch for readability * Clean up handleEntityDamageEvent Pattern variables, remove redundant check * Clean up handleEntityDamageEvent Remove redundant PVP check, add quick returns * Clean up handlePvpDamageByPlayer Use quick returns, extract duplicate code into a helper method * Clean up handlePvpDamageByPet Use quick returns, pattern variables, previously extracted helper method for duplicate code * Clean up handleClaimedBuildTrustDamageByEntity Use quick returns Remove unreachable code Note potential issues/missed cases * Extract handler for damage to pets by entities * Clean up handleCreatureDamageByEntity Use quick returns Remove unreachable villager handling Make last claim caching more consistent * Clean up handlePetDamageByEntity Use quick returns Previous patch to this area for display names of owners cleaned up most of the smells that were in the original cleanup PR * Clean up onEntityDamageMonitor Use quick returns, pattern variables Listen to more specific event (no need to duplicate event system's handling) Don't fetch player data for self-inflicted damage * Generalized cleanup Use existing local instances instead of static access - GriefPrevention is still a god object, but this is a step towards testability Annotate handlers Clean up a few comments * Don't send message if PreventPvPEvent is cancelled Also don't load pet owner name from disk if not sending messages. Theoretically doesn't cause issues because player-induced ignition should not occur if original damage was cancelled, but is an error. * Clean up onVehicleDamage Use quick returns and pattern variables, remove unnecessary guards * Clean up onPotionSplash partially This does not fully address potion splashing issues (namely, it still follows a completely different rule set from regular damage) but it is progress. Grammar corrections of effected -> affected. Add some missing positive and negative effects to support plugin-caused effects. Use pattern variables. Reduce duplicate code with claim PVP handler. * Fix certain raiders being unable to damage villagers More cases were previously "allowed" in an unreachable segment of code, but even that was missing several cases. * Fix edge case where projectiles could spam shooter Causing projectiles to ignore and pass through entities isn't easy to do "correctly" via the API without potentially becoming subtly incompatible with other plugins due to team manipulation. * Documentation, isMonster -> isHostile for clarity * Fix PVP by pet inconsistencies This is (technically) a behavioral change. Pets are prevented from engaging in PVP attacks if the defender is PVP immune. Theoretically this state is unable to occur in vanilla, but plugins could add additional triggers for pets attacking. Pets are no longer checked with PVP rules if PVP rules are not enabled. The assumption is that either vanilla PVP protection is in place or another PVP plugin is in place. - In vanilla, pets will not engage in PVP unprompted. Disabling PVP disables other players causing pets to attack, so an attack must be retaliatory. - If another PVP plugin is in place, it should handle all of PVP. * Remove redundant wolf PVP check, separate non-PVP check * Extract pet PVP handling to PVP section This will ideally make the code easier to follow and easier to move to modularize later. * Rename sendErrorMessagesToPlayers to sendMessages All messages are error messages, and the documentation exists. * Auto-format, restrict access to constants
-
Allow fluids to flow between claims of the same owner (#1218)
* Allow fluids to flow between claims of the same owner * Do not allow fluids to flow out of subdivisions * Don't allow fluids to flow into restricted subdivisions and refactor the logic for checking whether fluid flow is allowed between two claims
Commits on Jun 20, 2023
Commits on Jun 22, 2023
-
remove note about chat logging, bot for that has been removed a while ago :c
-
-
-
remove unused accrual permissions (#2074)
Leftovers that were missed when this feature was removed/migrated to API.
-
Prevent passive mobs from picking up PvE death drops (#2071)
* Remove deprecated PlayerPickupItemEvent and merge with entity logic
Commits on Jun 23, 2023
-
Improve re-drawing existing visualizations (#2081)
* Fix player visualization not being cleared when un-visualized Prevents issue where same visualization could not be re-displayed after it stopped due to scheduled revert * Fix visualization not re-drawing when moving
Commits on Jun 28, 2023
-
-
Fix potion thrower potentially being spammed denial (#2083)
* Fix inverted check causing denial spam
-
Restrict modifying signs (#2080)
* Restrict waxing signs * Also restrict signs in general
-
Commits on Jun 29, 2023
-
Avoid using Inventory.getHolder() in hopper check (#2086)
* Improve hopper pickup check The real change here is to use event.getInventory().getType(), rather than instanceof event.getInventory().getHolder(). The latter will return snapshots, and will therefore be especially slow when items have lots of metadata.
-
Don't use global firespread rules for wilderness TNT ignition by proj…
…ectiles (#2089) GP has never updated to account for Minecraft adding the ability to ignite TNT with flaming arrows in Minecraft 1.3.
Commits on Jul 12, 2023
Commits on Jul 18, 2023
-
Co-authored-by: RoboMWM <[email protected]>
-
Commits on Aug 8, 2023
-
Fix command usage not having correct casing (#2132)
Mojang does not ignore case when executing commands as a part of their chat signing feature. Spigot does not ignore case when executing commands due to wanting to keep a minimal diff. Spigot always lowercases commands when registered, so GP suggesting uppercase letters in its command feedback is confusing for users. Also remove some unused permission declarations
-
Fix Tameable protections (#2131)
* Fix PVP worlds not respecting claims for pets * Fix unclaimed wolves being protected * Fix claims not actually being respected
-
Use HashSet instead of EnumSet for Material (#2127)
EnumSet is generally more performant for sets of enum entries, however, the Material enum is colossal. This results in the creation of a JumboEnumSet internally, which consumes much more memory even with very few entries.
Commits on Aug 24, 2023
Commits on Oct 4, 2023
-
Remove EntityPortalExitEvent handling (#2124)
Deemed unnecessary per discussion in #2119
-
Commits on Oct 5, 2023
-
Fix aggressive panda handling (#2144)
* Aggressive pandas are reactive Aggressive pandas aggro if other pandas within a radius are attacked. All other types of pandas aggro if attacked. * Comment slime details
Commits on Oct 14, 2023
Commits on Jan 5, 2024
-
Protect decorated pots on 1.20.3+ (#2181)
Also fixes a paper issue introduced with 1.20.2 build 315: players not dropping items when in pvp. This bug was fixed in paper build 334.
Commits on Jan 8, 2024
-
Update api-version to 1.19 (#2192)
Recent commit uses decorated pots, which were added as a 1.20 preview feature in 1.19.4.
Commits on Jan 9, 2024
Commits on Feb 13, 2024
-
* Add uuid -> name cache * Add translation key for "someone (UUID)"
Commits on Feb 16, 2024
Commits on Feb 17, 2024
-
refactor EntityDamageByEntity handling to not use constructor (#2220)
* no longer using EntityDamageByEntityEvent for combust event * no longer using EntityDamageByEntityEvent for checking nametag handleing * stops the double message
-
Commits on Feb 20, 2024
-
Extract claim command from main class (#2090)
* Start work for command separation
Commits on Mar 2, 2024
-
Remove creative entity/tile limits (#2229)
* Remove creative entity/tile limits * Add in max dimensions for claim
-
-
Update actions Drop now-redundant cache action Drop Java 16 - Mockito cannot instrument classes for tests on 16 because Bukkit is compiled with Java 17 now
-
mvn install does indeed produce an artifact in target folder, so might as well just run that instead of an extra package command.
-
-
Improve pet release feature (#2226)
* Fix child claims always releasing pets even if parent is not * Compact logic to reduce indentation * Add unsitting Sittable pets to restore them to default state
-
Use BB logic for tree/portal creation (#1921)
* Use BB logic for tree/portal creation * Extract bounding box -> chunk claims logic to datastore * Extract intersection logic to helper methods * Apply intersection logic to tree growth This is a behavioral change. Old: GP allows tree to grow but removes all elements conflicting with claim New: GP determines that there is not enough room for the tree to grow, prevents the growth, and breaks the sapling * Apply intersection logic to nether portal creation (cherry picked from commit 979a77e) * Prevent blocks spreading into claims * Handles soul fire the same way as fire * Prevents sculk etc. growing into claims (cherry picked from commit 58cbf4f) * Prevent moss spreading into claims * Allow players with perms to grow trees into claims Reduces duplicate code a bit and improves QoL at claim edges. * Warn when denying access * Improve block burn efficiency Remove redundant fire unset Fix invalid fire unset Reorder check to not needlessly fetch claim if claimed blocks are allowed to burn * Soul fire doesn't spread, fix "extinguishing" non-fire * Fix external fires burning claimed blocks * Ignore grass growth Grass is inoffensive and causes the majority of normal spread events
Commits on Mar 8, 2024
-
Fix blocks not landing in subclaims from parent (#2245)
* Extract falling block handling * Add new behavior where falling blocks that have moved horizontally are removed when landing outside of a claim in SurvivalRequiringClaims mode * Allow block to fall from parent into unrestricted subclaim
Commits on Mar 15, 2024
-
* Support color in Paper console * Consider blank messages empty to help prevent blank line sending * Fix scheduling tasks when no message will be sent
Commits on Mar 29, 2024
-
Refactor and unify command monitoring logic (#2250)
- Feature: uses CommandMap via reflection if available. - gpreload command now also reloads bannedwords.txt
-
-
-
refactor duplicated damage handling code (#2252)
De-duplicates code by using a wrapper for the bits of damage events we care about.
-
-
Handle entities that pass through an end portal (#2246)
FallingBlock entities that pass through an end portal no longer double-fire EntityChangeBlockEvent
Commits on Apr 4, 2024
-
Include denying chorus fruit teleports when denying enderpearl telepo…
…rts (#2265) Includes denying teleportations caused by chorus fruit when the config option `GriefPrevention.Claims.EnderPearlsRequireAccessTrust` is enabled - refactored nested `if`s in PlayerTeleportEvent handler
Commits on Apr 9, 2024
-
-
normalize line endings in PlayerEventHandler
git add --renormalize . closes #2269
Commits on Apr 16, 2024
-
-
Remove old fire handling (#2263)
Fire has a real hit box now, clients hit it directly instead of the server raytracing swings at the block beneath it.
Commits on Apr 25, 2024
Commits on Apr 26, 2024
-
Ignore trash blocks when auto-extending (#2255)
This should ideally help prevent some issues with the main reason for having claims extend down instead of snapping to the bottom immediately, namely player mineshafts. Remove biomes from unsupported versions Update to current tags/mats
Commits on Apr 28, 2024
Commits on Jul 12, 2024
-
handle windcharges with new explosion type api + refactoring
* Update to 1.21 * Update to Java 21 * Move to more maintainable `PotionEffectTypeCategory` for potion handling * Use `Tag.REPLACEABLE` instead of manual material listing * This is the tag of blocks where placement on any surface becomes `BlockFace.SELF`. Includes long grass, dead shrubs, snow, short grass, the works. * Extract `GriefPrevention#allowBuild`/`GriefPrevention#allowBreak` to a helper method * These methods have been hacky since the introduction of the `ClaimPermissionCheckEvent`, and as we saw with damage events, Spigot is serious about event constructors not being API. Moving away from constructing events is a good idea in general. * Improves accuracy of event funnel by not masking various events with fake `BlockPlaceEvent`/`BlockBreakEvent` constructions. * Deprecate `PreventBlockBreakEvent` instead listen to `ClaimPermissionCheckEvent`, check `#getTriggeringEvent`. * Prevent claim lookup if ignoring the result anyway when milking cows * Update BanList to use modern version * Fix wind charges being blocked without `/claimexplosions` enabled This requires a recent build of Spigot - explosion type was only added to the API in [`a4ee40b7`](https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/a4ee40b749f614482f5b5e52cda1b35c19df75be), 4 days ago as of this edit. Closes #2320
Commits on Jul 14, 2024
-
Bundle default messages into Messages enum (#2329)
* Bundle defaults into Messages enum * Defaults are guaranteed to be updated this way - no more risk of missing adding the default. * IDE can now properly identify unused messages as unused because they are not being used to add defaults. * Update Minecraft wiki link * Use new comments API for comments
Commits on Jul 17, 2024
Commits on Jul 22, 2024
Commits on Jul 26, 2024
Commits on Aug 3, 2024
Commits on Aug 16, 2024
Commits on Aug 23, 2024
-
Fix NPE, restore PlayerData when using claim tool (#2359)
Initialization missed in 5d0ebde#diff-3e987f7e8304fdcbd9f9f571afbbebec186bc70583b97676a68c6b5aac604478L1924
-
Commits on Sep 7, 2024
-
Use separate file for database configuration (#2356)
* Migrate database configuration to separate file * Don't write file if not in use
Commits on Oct 7, 2024
Commits on Oct 12, 2024
-
Modify claimblock accrual idle detection and handling (#2371)
- Always call AccrueClaimBlocksEvent, even when player is detected as idle - Call AccrueClaimBlocksEvent as canceled if player is idle (default behavior) - Remove idle accrual config options - Use player direction for idle detection - Remove other checks such as location, in water, and in vehicles
Commits on Oct 31, 2024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.