Strange rssfeed option for "Movies" !RSSFeed.Options.Filter.filtType.Movie!

[n1diot]

For while while now I have had 4 options for "Type"

1. TVShow
2. !RSSFeed.Options.Filter.filtType.Movie!
3. Other
4. None

But the 2. !RSSFeed.Options.Filter.filtType.Movie! used to be called "Movie" I think, and gives the option to "Disable After Success"

First, the name is strange, second it doesn't disable after successful download completion.

I have tried;

• Manually editing the rssfeed.options file and remove anything with !RSSFeed.Options.Filter.filtType.Movie! which didn't work

• Removing all config files from AppData\Roaming\BiglyBT\plugins\rssfeed opening BiglyBT and the strange option for MOVIE is still their

• Uninstall the plugin, delete the entire rssfeed directory and re-install the plugin

I am at a loss myself, but I am not a programmer - and I did notice this with Vuze before moving to BiglyBT - which is GREAT! btw :)

• In addition, though I am not sure if I am correct, but it's almost like the TV history is not working correctly, yes it will download a PROPER when it comes out, but I have a vague memory that it downloaded a show twice.... not a real biggy on the TV side to be honest.

If anyone could assist me, or tell me this is normal operation now (as it used to work a long time ago and turn off the filter after successful download.

Regards;

[parg]

I just released 1.6.7 which fixes that text issue and another bug regarding seting the mode (to pass/fail). For me this fixed a few things but the guy that reported it says it is still failing for him :( Not sure about the 'disable after success' thing - it isn't my plugin but I have been making minor fixes to it for a while

[n1diot]

Hey Parg, thanks for the reply - and I do understand inheriting someone else's work, I am in I.T myself as a managed services provider, so I understand. I will try and find the 1.6.7 and install that.

You can only do what you can, I tend to check everyday for Movies, so I usually catch it before it downloads twice :)

If you do come up with something for the "Disable After Success" to work - you'd be a real gem!

Regards;

[n1diot]

OK - found the 1.6.7 plugin and installed. *Thank you for your efforts on this plugin!

I can confirm that;

1. The !RSSFeed.Options.Filter.filtType.Movie! now shows as MOVIE - I had to change quite a few of the movies from "TVShow" to "Movie" - or "Other" (which I had set myself to "Other" and changed to "Movie")

2. I will not be able to confirm if the disable after success will work until the next Movie comes out and downloads. But I am holding hope, as I mentioned in point 1. the !RSSFeed.Options.Filter.filtType.Movie! defaulted to "TVShow" and changing to "Movie" feels like something has potentially changed *here's hoping :)

3. I can also confirm that "Fail" - even being at the very top of the list does show Green, like in the following post : V1.6.6 broken mode and show type dropdowns revert to wrong value and cannot be saved #1

4. I hope I am incorrect, and my "TVShow" smart history is working!

• Seems to be keeping the history! Back until OCT 2017 - sorry about my terrible scrub out, but it's a private tracker :)

[parg]

Hi - I've been away for the last few days - please keep me posted on any issues! Thanks

[ferdnyc]

Hah! Turns out, "Disable after success" doesn't work because it's an option only for "Movie" type filters, but the code only applies it if the filter type is "Other". D'oh.

BiglyBT-plugin-rssfeed/org/kmallan/azureus/rssfeed/Scheduler.java

Lines 585 to 587 in 19a2e11

	boolean success = view.torrentDownloader.addTorrent(curLink, urlBean, filterBean, listBean);
	if(success && filterBean.getTypeIndex() == FilterBean.TYPE_OTHER && filterBean.getDisableAfter())
	filterBean.setEnabled(false);

[ferdnyc]

This is actually kind of a mess. Near as I can tell, the "Disable after use" option is supposed to be an option for the "Other" type, not "Movie". That's certainly what the comments imply. But there are a bunch of places in the HistoryBean and FilterTableItem code where the type value is interpreted as an integer, and filtDisable is associated with type index 1.

Problem is, inserting "Movie" as a type pushed "Other" to be the third option in that combo box, which means its actual index is 2, not 1.

BiglyBT-plugin-rssfeed/org/kmallan/azureus/rssfeed/FilterBean.java

Lines 36 to 39 in 19a2e11

	public static final int TYPE_TVSHOW = 0;
	public static final int TYPE_MOVIE = 1;
	public static final int TYPE_OTHER = 2;
	public static final int TYPE_NONE = 3;

BiglyBT-plugin-rssfeed/org/kmallan/azureus/rssfeed/View.java

Lines 674 to 684 in 19a2e11

	setupLabel(filtParamComp, "RSSFeed.Options.Filter.filtType", 75);
	filtType = new Combo(filtParamComp, SWT.DROP_DOWN | SWT.READ_ONLY);
	layoutData = new GridData();
	layoutData.widthHint = 200;
	filtType.setLayoutData(layoutData);
	filtType.add(MessageText.getString("RSSFeed.Options.Filter.filtType.TVShow"));
	filtType.add(MessageText.getString("RSSFeed.Options.Filter.filtType.Movie"));
	filtType.add(MessageText.getString("RSSFeed.Options.Filter.filtType.Other"));
	filtType.add(MessageText.getString("RSSFeed.Options.Filter.filtType.None"));
	filtType.select(0);
	filtType.addModifyListener(this);

BiglyBT-plugin-rssfeed/org/kmallan/azureus/rssfeed/View.java

Lines 730 to 736 in 19a2e11

	// Options Folder - Filter Params - Other Specific
	filtSpecificOther = setupComposite(filtSpecific, setupGridLayout(3, 0, 0, 0, 0), GridData.FILL_HORIZONTAL);
	(layoutData = new GridData()).widthHint = 35;
	(new Label(filtSpecificOther, SWT.NULL)).setLayoutData(layoutData);
	setupLabel(filtSpecificOther, "RSSFeed.Options.Filter.Other.Options", 75);
	filtDisable = new Button(filtSpecificOther, SWT.CHECK);
	Messages.setLanguageText(filtDisable, "RSSFeed.Options.Filter.Other.Options.Disable");

BiglyBT-plugin-rssfeed/org/kmallan/azureus/rssfeed/FilterTableItem.java

Lines 92 to 101 in 19a2e11

	switch(view.filtType.getSelectionIndex()) {
	case 0:
	view.filtStartSeason.setText(Integer.toString(data.getStartSeason()));
	view.filtStartEpisode.setText(Integer.toString(data.getStartEpisode()));
	view.filtEndSeason.setText(Integer.toString(data.getEndSeason()));
	view.filtEndEpisode.setText(Integer.toString(data.getEndEpisode()));
	view.filtSmartHist.setSelection(data.getUseSmartHistory());
	case 1:
	view.filtDisable.setSelection(data.getDisableAfter());
	break;

[ferdnyc]

The Movie type is also (based on lines 540-580 of Scheduler.java) supposed to support the same Smart History feature as TV Show, but there's no check box shown to enable it for that type.

[ferdnyc]

Also, just a random observation: This... is bananas. B-A-N-A-N-A-S.

BiglyBT-plugin-rssfeed/org/kmallan/azureus/rssfeed/View.java

Lines 1468 to 1508 in 19a2e11

	private void filtChooseSpecific(int curType) {
	GridData layoutData;
	switch(curType) {
	case 0:
	filtSpecificOther.setVisible(false);
	layoutData = new GridData();
	layoutData.heightHint = 0;
	filtSpecificOther.setLayoutData(layoutData);
	layoutData = new GridData(GridData.FILL_HORIZONTAL);
	filtSpecificTVShow.setLayoutData(layoutData);
	filtSpecificTVShow.setVisible(true);
	break;
	case 1:
	filtSpecificTVShow.setVisible(false);
	layoutData = new GridData();
	layoutData.heightHint = 0;
	filtSpecificTVShow.setLayoutData(layoutData);
	layoutData = new GridData(GridData.FILL_HORIZONTAL);
	filtSpecificOther.setLayoutData(layoutData);
	filtSpecificOther.setVisible(true);
	break;
	case 2:
	filtSpecificTVShow.setVisible(false);
	layoutData = new GridData();
	layoutData.heightHint = 0;
	filtSpecificTVShow.setLayoutData(layoutData);
	filtSpecificOther.setVisible(false);
	layoutData = new GridData();
	layoutData.heightHint = 0;
	filtSpecificOther.setLayoutData(layoutData);
	case 3:
	filtSpecificTVShow.setVisible(false);
	layoutData = new GridData();
	layoutData.heightHint = 0;
	filtSpecificTVShow.setLayoutData(layoutData);
	filtSpecificOther.setVisible(false);
	layoutData = new GridData();
	layoutData.heightHint = 0;
	filtSpecificOther.setLayoutData(layoutData);
	}

[parg]

I hate this plugin... Maybe you could send over a nice pull-request with everything working :)

Switches with case statements that drop through without a break - never liked the look of them and certainly wouldn't use it without a big comment saying that it was the intended behaviour...