Upgraded network library and corresponding API #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted the SerialDevice class and associated logic as that's been completely replaced by burt_network's SerialDevice and BurtFirmwareSerial
Levi-Lesches
previously approved these changes
Sep 26, 2024
There was a problem hiding this comment.
I also deleted SerialDevice as it has been replaced by burt_network's SerialDevice and BurtFirmwareSerial. The logic is the same but that one has unit tests, it's shared with the on-rover code, and it uses streams instead of overriding methods (similar to how BurtSocket works)
Levi-Lesches
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.