Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from fl_chart to syncfusion for graphs #172

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Gold872
Copy link
Member

@Gold872 Gold872 commented Oct 1, 2024

This will fix the memory leak issue with pages that have graphs on them. Syncfusion graphs don't look as pretty but are much more efficient

image

Copy link
Member

@Levi-Lesches Levi-Lesches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

  • That's a pretty significant visual downgrade, with the jagged edges... if it must be done, okay, but it would be sad
  • Can you test, with the latest fl_chart version possible (use dart pub outdated or check Pub, because there was a memory leak fixed) if the issues still happen on the science page? If not, I think we can keep with the current approach, even though I don't love the API
  • Besides efficiency and API, are there any other advantages to sync_fusion over fl_chart?

Comment on lines +29 to +45
List<CartesianSeries<SensorReading, double>> getChartSeries() {
final result = <CartesianSeries<SensorReading, double>>[];
for (int i = 0; i < readings.length; i++) {
result.add(
LineSeries(
animationDuration: 0,
dataLabelMapper: (datum, index) => "${datum.value} $sideUnitName",
color: colors[i],
xValueMapper: (datum, index) => datum.time / 1000,
yValueMapper: (datum, index) => datum.value,
dataSource: readings[i].toList(),
width: 2.5,
),
);
}
return result;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
List<CartesianSeries<SensorReading, double>> getChartSeries() {
final result = <CartesianSeries<SensorReading, double>>[];
for (int i = 0; i < readings.length; i++) {
result.add(
LineSeries(
animationDuration: 0,
dataLabelMapper: (datum, index) => "${datum.value} $sideUnitName",
color: colors[i],
xValueMapper: (datum, index) => datum.time / 1000,
yValueMapper: (datum, index) => datum.value,
dataSource: readings[i].toList(),
width: 2.5,
),
);
}
return result;
}
List<CartesianSeries<SensorReading, double>> getChartSeries() => [
for (int i = 0; i < readings.length; i++) LineSeries(
animationDuration: 0,
dataLabelMapper: (datum, index) => "${datum.value} $sideUnitName",
color: colors[i],
xValueMapper: (datum, index) => datum.time / 1000,
yValueMapper: (datum, index) => datum.value,
dataSource: readings[i].toList(),
width: 2.5,
),
];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants