-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from fl_chart to syncfusion for graphs #172
Draft
Gold872
wants to merge
2
commits into
main
Choose a base branch
from
syncfusion-graphs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Lesches
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
- That's a pretty significant visual downgrade, with the jagged edges... if it must be done, okay, but it would be sad
- Can you test, with the latest
fl_chart
version possible (usedart pub outdated
or check Pub, because there was a memory leak fixed) if the issues still happen on the science page? If not, I think we can keep with the current approach, even though I don't love the API - Besides efficiency and API, are there any other advantages to sync_fusion over fl_chart?
Comment on lines
+29
to
+45
List<CartesianSeries<SensorReading, double>> getChartSeries() { | ||
final result = <CartesianSeries<SensorReading, double>>[]; | ||
for (int i = 0; i < readings.length; i++) { | ||
result.add( | ||
LineSeries( | ||
animationDuration: 0, | ||
dataLabelMapper: (datum, index) => "${datum.value} $sideUnitName", | ||
color: colors[i], | ||
xValueMapper: (datum, index) => datum.time / 1000, | ||
yValueMapper: (datum, index) => datum.value, | ||
dataSource: readings[i].toList(), | ||
width: 2.5, | ||
), | ||
); | ||
} | ||
return result; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
List<CartesianSeries<SensorReading, double>> getChartSeries() { | |
final result = <CartesianSeries<SensorReading, double>>[]; | |
for (int i = 0; i < readings.length; i++) { | |
result.add( | |
LineSeries( | |
animationDuration: 0, | |
dataLabelMapper: (datum, index) => "${datum.value} $sideUnitName", | |
color: colors[i], | |
xValueMapper: (datum, index) => datum.time / 1000, | |
yValueMapper: (datum, index) => datum.value, | |
dataSource: readings[i].toList(), | |
width: 2.5, | |
), | |
); | |
} | |
return result; | |
} | |
List<CartesianSeries<SensorReading, double>> getChartSeries() => [ | |
for (int i = 0; i < readings.length; i++) LineSeries( | |
animationDuration: 0, | |
dataLabelMapper: (datum, index) => "${datum.value} $sideUnitName", | |
color: colors[i], | |
xValueMapper: (datum, index) => datum.time / 1000, | |
yValueMapper: (datum, index) => datum.value, | |
dataSource: readings[i].toList(), | |
width: 2.5, | |
), | |
]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the memory leak issue with pages that have graphs on them. Syncfusion graphs don't look as pretty but are much more efficient