Correct non-overlapping query

BioJulia · May 21, 2020 · 0091cb3 · 0091cb3
1 parent a63ab3c
commit 0091cb3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/intervalcollection.jl b/src/intervalcollection.jl
@@ -289,12 +289,13 @@ end
 # Overlaps
 # --------
 
-function eachoverlap(a::IntervalCollection{T}, b::Interval; filter::F = true_cmp) where {F,T}
-    if haskey(a.trees, b.seqname)
-        return intersect(a.trees[b.seqname], b)
+function eachoverlap(a::IntervalCollection{T}, query::Interval; filter::F = true_cmp) where {F,T}
+    if haskey(a.trees, query.seqname)
+        return ICTreeIntervalIntersectionIterator{F,T}(filter, ICTreeIntersection{T}(), a.trees[query.seqname], query)
     end
 
-    return ICTreeIntervalIntersectionIterator{F,T}()
+    return ICTreeIntervalIntersectionIterator{F,T}(filter, ICTreeIntersection{T}(), ICTree{T}(), query)
+
 end
 
 function eachoverlap(a::IntervalCollection, b::IntervalCollection; filter = true_cmp)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -414,6 +414,9 @@ end #testset Constructor Conversions
         iter3 = eachoverlap(ic_a, intervals_b)
         iter4 = eachoverlap(ic_a, ic_b)
         @test collect(iter1) == collect(iter2) == collect(iter3) == collect(iter4)
+
+        # non-overlapping query
+        @test length(collect(eachoverlap(ic_a, Interval("X", 0, 0)))) == 0
     end
 end
 end #testset GenomicFeatures