Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paleo fields to the Data Editor Search Form #1900

Open
wants to merge 2 commits into
base: paleo-test
Choose a base branch
from

Conversation

NikitaSalikov
Copy link
Collaborator

Changes Made:

  • Added Paleo fields to the Record Search Form's fields selector
  • Added Paleo update functionality to Batch Update Tool (?)

Batch Update Issue:

@egbot , as we previously discussed, there's an issue with omoccurredits table (OccurrenceEditorManager starting line ~2007):
omoccurredits table doesn't have paleo fields columns. Should we add them to the table?

Currently the code is skipping the INSERT INTO omoccurredits table if Paleo fields are present. Not the final solution, just for testing.

Pull Request Checklist:

Pre-Approval

Post-Approval

  • It is the code author's responsibility to merge their own pull request after it has been approved
  • If this PR represents a merge into the Development branch, remember to use the squash & merge option
  • If this PR represents a merge into the hotfix branch, remember to use the merge option (i.e., no squash).
  • If this PR represents a merge from the Development branch into the master branch, remember to use the merge option
  • If this PR represents a merge from the hotfix branch into the master branch use the squash & merge option
    • a subsequent PR from master into Development should be made with the merge option (i.e., no squash).
    • Immediately delete the hotfix branch and create a new hotfix branch
    • increment the Symbiota version number in the symbase.php file and commit to the hotfix branch.
  • If the dev team has agreed that this PR represents the last PR going into the Development branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock the Development branch to prevent accidental merges while QA takes place. Follow the release protocol here.
  • Don't forget to delete your feature branch upon merge. Ignore this step as required.

Thanks for contributing and keeping it clean!

@ljwalker
Copy link
Collaborator

omoccurredits table doesn't have paleo fields columns. Should we add them to the table?

This seems like a good suggestion to me.

@ljwalker
Copy link
Collaborator

ljwalker commented Feb 7, 2025

Original notes from discussions between SSH dev+Lindsay:

  • Need to discuss complexity of searching for age-related values, with consideration for who will be using this form (data managers). E.g. if searching on "Late Cretaceous", do you only want records where the hand-keyed value is "Late Cretaceous", and thus so you can batch edit these values, or do you want to recall all records with child relationships to "Late Cretaceous", e.g. "Santonian", "Coniacian", etc.
  • Will need to test thoroughly with respect to the batch editing vs. pure searching tools.

Responses to questions posed above from GEO OSE/paleo PI team (from 2024-12-12):

  • Enable searching on specific age-related ranks, e.g. eon vs era vs. period, as well as earlyInterval and lateInterval.
  • Being able to search on exact values and ranges of values would be ideal.
  • Generally, more comprehensive searching/querying options is more desirable than less for this user interface.
  • Is there a way to ensure that the Batch Replace tool does not allow addition of illogical values, as will be the case on the Occurrence Editor?
    • Does batch editing of earlyInterval or lateInterval values make sense? (i.e. These fields may behave similarly to sciName, which you currently cannot batch edit. Would a bulk data ingestion be a better way to update these values in mass?)

(Note that this feedback is specific to the Data Editor Search Form/not related to the Public Search form.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants