-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.3] Additional identifiers using extended data importer #2183
base: Development
Are you sure you want to change the base?
[3.3] Additional identifiers using extended data importer #2183
Conversation
…lements and add new option for identifiers
…upload file and address generating those data on the fly. Fixed for insertIdentifier but still out of order for updateIdentifier
$this->logOrEcho('ERROR loading Material Sample: ' . $importManager->getErrorMessage(), 1); | ||
} | ||
} | ||
} elseif ($this->importType == self::IMPORT_IDENTIFIERS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only area that is a new addition; the rest is autoformatting fixes.
|
Ok. I think that I fixed this in 578a7a5, but @themerekat it's worth checking that it has the result that you're expecting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add, update, and delete all seem to be working!
Description
This PR implements bulk upload of custom identifiers. End users need to provide either occurrenceID, catalogNumber, or otherCatalogNumbers, as well as identifierName and identifierValue. format, notes, sortBy, and recordID are optional.
End users also have the option to update existing identifier entries in the omoccuridentifiers table, as well as delete.
Pull Request Checklist:
Pre-Approval
master
branch and PR'd using the merge option (not squashed) into thehotfix
branch.Development
branch, NOTmaster
Post-Approval
Development
branch, remember to use the squash & merge optionhotfix
branch, remember to use the merge option (i.e., no squash).Development
branch into the master branch, remember to use the merge optionhotfix
branch into themaster
branch use the squash & merge optionmaster
intoDevelopment
should be made with the merge option (i.e., no squash).hotfix
branch and create a newhotfix
branchhotfix
branch.Development
branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopment
branch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!