Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds autocomplete to otherCatalogNumbers tag names #2218

Open
wants to merge 1 commit into
base: Development
Choose a base branch
from

Conversation

mickley
Copy link
Collaborator

@mickley mickley commented Feb 13, 2025

This adds autocomplete to the optional Tag Name box associated with otherCatalogNumbers. The autocomplete is collection-specific, allowing each collection to autocomplete with their own terms. In addition to providing autocomplete when the user starts typing, if the user clicks into an empty tag name box, it will provide a dropdown of all the previously used tag names in that collection.

I believe that someone asked about this feature in the December SSH support group meeting. It's a time-saver (no need to type "Accession Number" over and over), but more importantly, it would help ensure that this field uses a controlled vocabulary. Otherwise, I can foresee all sorts of typos.

It searches the omoccuridentifiers table for all tag names belonging to that collection. It can be a bit slow. Perhaps an index on omoccuridentifiers.identifiername would help, or maybe there is a better way to implement the query in RpcOccurrenceEditor.php.

Also, I've fixed a minor formatting bug.

Previously, when additional rows were added to the otherCatalogNumbers table (collections.editor.main, addIdentifierField()), the input boxes were missing a class name (IdNameInput, and idValueInput). I've added these.

Pull Request Checklist:

Pre-Approval

  • There is a description section in the pull request that details what the proposed changes do. It can be very brief if need be, but it ought to exist.
  • Hotfixes should be branched off of the master branch and PR'd using the merge option (not squashed) into the hotfix branch.
  • Features and backlog bugs should be merged into the Development branch, NOT master
  • All new text is preferably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages), and the spreadsheet tracking internationalizations has been updated either with a new row or with checkmarks to existing rows.
  • There are no linter errors
  • New features have responsive design (i.e., look aesthetically pleasing both full screen and with small or mobile screens)
  • Symbiota coding standards have been followed
  • If any files have been reformatted (e.g., by an autoformatter), the reformat is its own, separate commit in the PR
  • Comment which GitHub issue(s), if any does this PR address
  • If this PR makes any changes that would require additional configuration of any Symbiota portals outside of the files tracked in this repository, make sure that those changes are detailed in this document.

Post-Approval

  • It is the code author's responsibility to merge their own pull request after it has been approved
  • If this PR represents a merge into the Development branch, remember to use the squash & merge option
  • If this PR represents a merge into the hotfix branch, remember to use the merge option (i.e., no squash).
  • If this PR represents a merge from the Development branch into the master branch, remember to use the merge option
  • If this PR represents a merge from the hotfix branch into the master branch use the squash & merge option
    • a subsequent PR from master into Development should be made with the merge option (i.e., no squash).
    • Immediately delete the hotfix branch and create a new hotfix branch
    • increment the Symbiota version number in the symbase.php file and commit to the hotfix branch.
  • If the dev team has agreed that this PR represents the last PR going into the Development branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock the Development branch to prevent accidental merges while QA takes place. Follow the release protocol here.
  • Don't forget to delete your feature branch upon merge. Ignore this step as required.

Thanks for contributing and keeping it clean!

- The autocomplete is collection-specific.
- If the user clicks into an empty tag name box, they will be shown a dropdown of options for that collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant