forked from egbot/Symbiota
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.3] Openid logout #2224
Open
Atticus29
wants to merge
44
commits into
Development
Choose a base branch
from
openid_logout
base: Development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[3.3] Openid logout #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature to alert authentication provider of a local logout to end tracked session.
testing - dump $oidc obj to log
test
testcode Co-Authored-By: Mark <[email protected]>
debug with IP Co-Authored-By: Mark <[email protected]>
… the useraccesstokens table
debug Co-Authored-By: Mark <[email protected]>
Co-Authored-By: Mark <[email protected]>
Co-Authored-By: Mark <[email protected]>
Co-Authored-By: Mark <[email protected]>
Co-Authored-By: Mark <[email protected]>
proof of concept using symbbase Co-Authored-By: Mark <[email protected]>
add more logging Co-Authored-By: Mark <[email protected]>
Code Clean up Add response headers for logout.php Co-Authored-By: Mark <[email protected]>
broke something.
egbot
requested changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but haven't actually tested the code since I figure that both you and Greg have already test that part thoroughly, but I do have a few comments:
- Should the variables within the auth_config_template.php be uppercase indicating that they are global variables that will not be changed. Given that this is how we are doing it within the symbini.php configuration file.
- We have only been entering local paths within the symbini.php configuration path with full paths generated within the code. This is particularly true when host is needed, since we can then use the GeneralUtil::getDomain() within the openIdAuth.php page to build full path, which is optimized to obtain the correct domain whether or not SERVER_HOST is properly set within symbini file, and it will self resolve certificate settings (http vs https) and port number.
- Make sure not to merge into Development branch until after 3.2 is officialized and merged into Master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the third party authentication workflow by propagating a remote logout in the auth provider to kill local Symbiota sessions. In other words, if you log out on, say, Microsoft (assuming it's the auth provider for your third party login), it automatically logs you out of your Symbiota session as well.
Pull Request Checklist:
Pre-Approval
master
branch and PR'd using the merge option (not squashed) into thehotfix
branch.Development
branch, NOTmaster
Post-Approval
Development
branch, remember to use the squash & merge optionhotfix
branch, remember to use the merge option (i.e., no squash).Development
branch into the master branch, remember to use the merge optionhotfix
branch into themaster
branch use the squash & merge optionmaster
intoDevelopment
should be made with the merge option (i.e., no squash).hotfix
branch and create a newhotfix
branchhotfix
branch.Development
branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopment
branch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!