Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-273 - Feature/sylius 1.13 update #241

Merged
merged 20 commits into from
May 13, 2024
Merged

OP-273 - Feature/sylius 1.13 update #241

merged 20 commits into from
May 13, 2024

Conversation

BartoszWojdalowicz
Copy link
Contributor

No description provided.

@BartoszWojdalowicz
OP-273 - remove sylius 1.11 config files
0687ae3
@BartoszWojdalowicz
OP-273 - add missing changes from sylius upgrade guide
c16b94a
@BartoszWojdalowicz
OP-273 - set package.json.1.13 as default packages.json
f3a3c6e
@BartoszWojdalowicz
OP-273 - order composer packages in alphabetical order, remove sylius…
ff8f78a 
… 1.11 support, update dependencies
@BartoszWojdalowicz
OP-273 - update composer.json
15a8605
@BartoszWojdalowicz
update symfony workflow build
fdc021f
@BartoszWojdalowicz
upgrade bitbag coding standard package
fa1bb7f
@BartoszWojdalowicz
fix gh action build configuration
0882627
@BartoszWojdalowicz
fix gh action config
0f3f41b
@BartoszWojdalowicz
OP-273 - temporary disable gh action on push
f0f53dd
@BartoszWojdalowicz
OP-273 - downgrade bitbag coding standards package
cfd10d1
@BartoszWojdalowicz
OP-273 - update ecs configuration
dcf101c
@BartoszWojdalowicz
OP-273 - fix ecs
8201327
@BartoszWojdalowicz
OP-273 - remove symfony flex package
fbde925
@BartoszWojdalowicz
fix phpspec test
ba52c27
@BartoszWojdalowicz
OP-273 - add conflict with behat/mink-selenium2-driver
028654e
@BartoszWojdalowicz
OP-273 - set 2 decimal digit in behat tests. Add node information in …
5d6f909 
…gh actions
@BartoszWojdalowicz
OP-273 - set thousends coma in behat scenarios.
88ab370
@BartoszWojdalowicz BartoszWojdalowicz changed the title Feature/sylius 1.13 update OP-273 - Feature/sylius 1.13 update May 10, 2024
senghe
senghe approved these changes May 13, 2024
View reviewed changes
src/Model/SearchFacets.php
@@ -34,7 +34,7 @@ public function __set(string $facetId, $selectedBuckets)

public function __isset(string $facetId)
{
return isset($this->selectedBuckets[$facetId]);
return true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to remember this solution is very temporary 🖖

@BartoszWojdalowicz BartoszWojdalowicz merged commit 3349335 into master May 13, 2024
96 checks passed
@TakesTheBiscuit
Copy link

TakesTheBiscuit commented May 13, 2024 •
edited
Loading

I think this has caused a breaking change in sylius b2bkit, raising a defect with sylius support.


8.043 !!    The service "BitBag\SyliusElasticsearchPlugin\Transformer\Product\ChannelPr
8.043 !!    icingTransformer" has a dependency on a non-existent service "Sylius\Compon
8.043 !!    ent\Product\Resolver\ProductVariantResolverInterface". Did you mean one of
8.043 !!    these: "Sylius\Component\Product\Factory\ProductVariantFactoryInterface", "
8.043 !!    Sylius\Component\Product\Factory\ProductFactoryInterface", "Sylius\Componen
8.043 !!    t\Order\Remover\ExpiredCartsRemoverInterface", "Sylius\Component\Product\Ge
8.043 !!    nerator\ProductVariantGeneratorInterface", "Sylius\Component\Product\Checke
8.043 !!    r\ProductVariantsParityCheckerInterface", "Sylius\Component\Product\Resolve
8.043 !!    r\AvailableProductOptionValuesResolverInterface", "Sylius\Component\Taxatio
8.043 !!    n\Resolver\TaxRateResolverInterface", "Sylius\Component\Payment\Resolver\Pa
8.043 !!    ymentMethodsResolverInterface", "Sylius\Component\Payment\Resolver\DefaultP
8.044 !!    aymentMethodResolverInterface"?

GSadee
GSadee reviewed May 14, 2024
View reviewed changes
.github/workflows/build.yml
symfony: "^6.0"
php: [ "8.1", "8.2", "8.3" ]
symfony: [ "^5.4", "^6.0" ]
sylius: [ "^1.12", "^1.13" ]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^1.12 installs the Sylius 1.13, so now version 1.12 is not tested at all, you need to change that to ~1.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@senghe senghe senghe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BartoszWojdalowicz @TakesTheBiscuit @senghe @GSadee