Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend accountsummary clickable #2987

Merged

Conversation

thisconnect
Copy link
Collaborator

No description provided.

Changed to use an internal component instead of storing some JSX
in a variable so it is slightly more readable.
On mobile it makes sense to have the whole row clickable.

On desktop some users might want to be able to select and copy
text from the summary table.
Copy link
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisconnect thisconnect merged commit ddbc7c1 into BitBoxSwiss:master Oct 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants