Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: hide buttontext of header buttons on small screen #2989

Merged

Conversation

thisconnect
Copy link
Collaborator

Depending on translation, font-rendering on different platforms and
screensize the header buttons sometime break to a new line.

Changed to hide the button text on small screen and only use icons.

This is not used anymore and was introduced in commit:
- 5c9147c
Depending on translation, font-rendering on different platforms and
screensize the header buttons sometime break to a new line.

Changed to hide the button text on small screen and only use icons.
As the account-info button is only visible on the account overview
it makes sense to show it first.
@thisconnect
Copy link
Collaborator Author

current master:

Screenshot 2024-10-19 at 13 00 33 Screenshot 2024-10-19 at 13 00 45 Screenshot 2024-10-19 at 13 01 02

@thisconnect
Copy link
Collaborator Author

with this change:

Screenshot 2024-10-19 at 13 03 31 Screenshot 2024-10-19 at 13 03 17 Screenshot 2024-10-19 at 13 02 56

Copy link
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested

@thisconnect thisconnect merged commit 200acc6 into BitBoxSwiss:master Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants