chore(eth-multisig-v4): add bera config #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianchandania
requested changes
Aug 8, 2024
| @@ -35,6 +35,7 @@ jobs: | |||
| ARBISCAN_API_KEY: ${{ secrets.ARBISCAN_API_KEY }} | |||
| OPTIMISTIC_ETHERSCAN_API_KEY: ${{ secrets.OPTIMISTIC_ETHERSCAN_API_KEY }} | |||
| ZKSYNC_EXPLORER_API_KEY: ${{ secrets.ZKSYNC_EXPLORER_API_KEY }} | |||
| BARTIO_BERA_EXPLORER_API_KEY: ${{ secrets.BARTIO_BERA_EXPLORER_API_KEY }} | |||
There was a problem hiding this comment.
Is the key already added in github secrets?
hardhat.config.ts
Outdated
| @@ -121,6 +122,10 @@ const config: HardhatUserConfig = { | |||
| tzketh: { | |||
| url: `${QUICKNODE_ZKSYNC_SEPOLIA_API_KEY}`, | |||
| accounts: [`${PRIVATE_KEY_FOR_V4_CONTRACT_DEPLOYMENT}`] | |||
| }, | |||
| tbera: { | |||
| url: `${BARTIO_BERA_EXPLORER_API_KEY}`, | |||
There was a problem hiding this comment.
Here you don't need Explorer API key. You need to add public rpc url for bera as this will be used to deploy the contracts
There was a problem hiding this comment.
fixed it. just realized when i was trying to run in my local
hardhat.config.ts
Outdated
| @@ -189,6 +196,15 @@ const config: HardhatUserConfig = { | |||
| browserURL: 'https://sepolia.explorer.zksync.io' | |||
| } | |||
| }, | |||
| { | |||
| network: 'berachainbArtio', | |||
scripts/deploy.ts
Outdated
| @@ -79,6 +79,10 @@ async function main() { | |||
| walletImplementationContractName = 'ZkethWalletSimple'; | |||
| contractPath = `contracts/coins/${walletImplementationContractName}.sol:${walletImplementationContractName}`; | |||
| break; | |||
| case 80084: | |||
| walletImplementationContractName = 'BeraWalletSimple'; | |||
There was a problem hiding this comment.
It should be WalletSimple
There was a problem hiding this comment.
Also need to add
forwarderContractName = 'ForwarderV4';
forwarderFactoryContractName = 'ForwarderFactoryV4';
There was a problem hiding this comment.
Thanks, i followed the zksync so might have missed these
scripts/deploy.ts
Outdated
| @@ -79,6 +79,10 @@ async function main() { | |||
| walletImplementationContractName = 'ZkethWalletSimple'; | |||
| contractPath = `contracts/coins/${walletImplementationContractName}.sol:${walletImplementationContractName}`; | |||
| break; | |||
| case 80084: | |||
| walletImplementationContractName = 'BeraWalletSimple'; | |||
| contractPath = `contracts/coins/${walletImplementationContractName}.sol:${walletImplementationContractName}`; | |||
There was a problem hiding this comment.
contractPath = contracts/${walletImplementationContractName}.sol:${walletImplementationContractName};
package-lock.json
Outdated
There was a problem hiding this comment.
There is no new module that is added, we should not commit package-lock in that case
yarn.lock
Outdated
There was a problem hiding this comment.
We should not commit this as no new module is added
adarsh312
force-pushed
the
WIN-3295_walletSimple_contract
branch
from
6f7477b
to
be622e1
Compare
adarsh312
force-pushed
the
WIN-3295_walletSimple_contract
branch
from
0f89091
to
b5a9563
Compare
adarsh312
force-pushed
the
WIN-3295_walletSimple_contract
branch
from
b5a9563
to
5b256f8
Compare
adarsh312
force-pushed
the
WIN-3295_walletSimple_contract
branch
from
5b256f8
to
b757d0b
Compare
adarsh312
force-pushed
the
WIN-3295_walletSimple_contract
branch
from
b757d0b
to
388c424
Compare
kamleshmugdiya
requested changes
Aug 14, 2024
| if: ${{ (needs.get-network.outputs.network == 'hteth' ) || (needs.get-network.outputs.network == 'tmatic' ) || (needs.get-network.outputs.network == 'tbsc' ) || (needs.get-network.outputs.network == 'tarbeth' ) || (needs.get-network.outputs.network == 'topeth' ) || (needs.get-network.outputs.network == 'tzketh' ) || (needs.get-network.outputs.network == 'tbaseeth' )}} | ||
| ======= | ||
| if: ${{ (needs.get-network.outputs.network == 'hteth' ) || (needs.get-network.outputs.network == 'tmatic' ) || (needs.get-network.outputs.network == 'tbsc' ) || (needs.get-network.outputs.network == 'tarbeth' ) || (needs.get-network.outputs.network == 'topeth' ) || (needs.get-network.outputs.network == 'tzketh' ) || (needs.get-network.outputs.network == 'tbera' ) }} | ||
| >>>>>>> 5b256f8 (chore(eth-multisig-v4): add bera config) |
There was a problem hiding this comment.
this should not be pushed, right?
kamleshmugdiya
approved these changes
Aug 14, 2024
gianchandania
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.