feat(eth-multisig-v4): add deploy batcher smart contract in workflow #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There shouldn't be multiple commits, rebase them to have single commit. |
mohitkh7
requested changes
Aug 21, 2024
mohitkh7
reviewed
Aug 21, 2024
therealdwright
requested changes
Sep 3, 2024
MohammedRyaan786
force-pushed
the
COIN-716-add-a-script-and-github-action-workflow-to-deploy-batcher-smart-contracts-in-eth-multisig-v-4-repo
branch
from
a2059d6
to
e35d1e1
Compare
MohammedRyaan786
temporarily deployed
to
dev
GitHub Actions
Inactive
MohammedRyaan786
temporarily deployed
to
dev
GitHub Actions
Inactive
MohammedRyaan786
temporarily deployed
to
dev
GitHub Actions
Inactive
therealdwright
requested changes
Sep 12, 2024
mohitkh7
approved these changes
Sep 13, 2024
MohammedRyaan786
force-pushed
the
COIN-716-add-a-script-and-github-action-workflow-to-deploy-batcher-smart-contracts-in-eth-multisig-v-4-repo
branch
from
056b7d6
to
fb224eb
Compare
MohammedRyaan786
had a problem deploying
to
dev
GitHub Actions
Failure
MohammedRyaan786
had a problem deploying
to
dev
GitHub Actions
Failure
MohammedRyaan786
force-pushed
the
COIN-716-add-a-script-and-github-action-workflow-to-deploy-batcher-smart-contracts-in-eth-multisig-v-4-repo
branch
from
fb224eb
to
73941e1
Compare
MohammedRyaan786
temporarily deployed
to
dev
GitHub Actions
Inactive
MohammedRyaan786
temporarily deployed
to
dev
GitHub Actions
Inactive
|
@therealdwright could you please review this PR? |
|
@therealdwright could I please get your review here? |
therealdwright
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: COIN-716