Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact creation makefile commands. #1596

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

tchalvak
Copy link
Member

@tchalvak tchalvak commented Dec 1, 2023

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

@tchalvak tchalvak force-pushed the feat/create-artifacts branch from 1a26f72 to 240a78e Compare December 1, 2023 23:21
@tchalvak tchalvak enabled auto-merge December 1, 2023 23:23
Copy link

cypress bot commented Dec 1, 2023

Passing run #62 ↗︎

0 8 0 0 Flakiness 0

Details:

Merge 240a78e into 7cc4b0d...
Project: NinjaWars Functional Testing Commit: 9cb2ee1c98 ℹ️
Status: Passed Duration: 01:31 💡
Started: Dec 1, 2023 11:22 PM Ended: Dec 1, 2023 11:24 PM

Review all test suite changes for PR #1596 ↗︎

@tchalvak tchalvak merged commit 94d55b0 into master Dec 1, 2023
3 checks passed
@tchalvak tchalvak deleted the feat/create-artifacts branch December 1, 2023 23:24
Copy link

cypress bot commented Dec 1, 2023

Passing run #63 ↗︎

0 8 0 0 Flakiness 0

Details:

Merge pull request #1596 from BitLucid/feat/create-artifacts
Project: NinjaWars Functional Testing Commit: 94d55b0af5
Status: Passed Duration: 01:27 💡
Started: Dec 1, 2023 11:25 PM Ended: Dec 1, 2023 11:26 PM

Review all test suite changes for PR #1596 ↗︎

@tchalvak tchalvak restored the feat/create-artifacts branch December 7, 2023 04:02
@tchalvak tchalvak deleted the feat/create-artifacts branch December 7, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant