Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/signup testing improve #1599

Merged
merged 9 commits into from
Dec 9, 2023
Merged

Feat/signup testing improve #1599

merged 9 commits into from
Dec 9, 2023

Conversation

tchalvak
Copy link
Member

@tchalvak tchalvak commented Dec 9, 2023

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

Copy link

cypress bot commented Dec 9, 2023

Passing run #94 ↗︎

0 8 0 0 Flakiness 0

Details:

Merge a5af078 into 4f26e59...
Project: NinjaWars Functional Testing Commit: 0f86e739d6 ℹ️
Status: Passed Duration: 01:31 💡
Started: Dec 9, 2023 3:38 AM Ended: Dec 9, 2023 3:40 AM

Review all test suite changes for PR #1599 ↗︎

@tchalvak tchalvak enabled auto-merge December 9, 2023 03:37
This commit fixes the style issues introduced in 9d67383 according to the output
from PHP CS Fixer.

Details: #1599
@tchalvak tchalvak merged commit f6d868f into master Dec 9, 2023
3 checks passed
@tchalvak tchalvak deleted the feat/signup-testing-improve branch December 9, 2023 03:41
Copy link

cypress bot commented Dec 9, 2023

Passing run #95 ↗︎

0 8 0 0 Flakiness 0

Details:

Merge pull request #1599 from BitLucid/feat/signup-testing-improve
Project: NinjaWars Functional Testing Commit: f6d868f97a
Status: Passed Duration: 01:26 💡
Started: Dec 9, 2023 3:41 AM Ended: Dec 9, 2023 3:43 AM

Review all test suite changes for PR #1599 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant