Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typehint change for status test. #1602

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Minor typehint change for status test. #1602

merged 1 commit into from
Dec 9, 2023

Conversation

tchalvak
Copy link
Member

@tchalvak tchalvak commented Dec 9, 2023

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

@tchalvak tchalvak enabled auto-merge December 9, 2023 04:34
Copy link

cypress bot commented Dec 9, 2023

Passing run #102 ↗︎

0 8 0 0 Flakiness 0

Details:

Merge f66e2dc into 75f8229...
Project: NinjaWars Functional Testing Commit: f1ed9daa13 ℹ️
Status: Passed Duration: 01:24 💡
Started: Dec 9, 2023 4:35 AM Ended: Dec 9, 2023 4:36 AM

Review all test suite changes for PR #1602 ↗︎

@tchalvak tchalvak merged commit 485919e into master Dec 9, 2023
3 checks passed
@tchalvak tchalvak deleted the feat/status-test branch December 9, 2023 04:37
Copy link

cypress bot commented Dec 9, 2023

Passing run #103 ↗︎

0 8 0 0 Flakiness 0

Details:

Merge pull request #1602 from BitLucid/feat/status-test
Project: NinjaWars Functional Testing Commit: 485919e316
Status: Passed Duration: 01:26 💡
Started: Dec 9, 2023 4:37 AM Ended: Dec 9, 2023 4:39 AM

Review all test suite changes for PR #1602 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant