Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ninjamaster links and validation fixes. #1610

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Ninjamaster links and validation fixes. #1610

merged 1 commit into from
Dec 29, 2023

Conversation

tchalvak
Copy link
Member

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

Copy link

cypress bot commented Dec 29, 2023

Passing run #119 ↗︎

0 8 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c2c938c into 7a4f699...
Project: NinjaWars Functional Testing Commit: b91781e17b ℹ️
Status: Passed Duration: 01:37 💡
Started: Dec 29, 2023 10:29 PM Ended: Dec 29, 2023 10:31 PM

Review all test suite changes for PR #1610 ↗︎

@tchalvak tchalvak merged commit ec38e05 into master Dec 29, 2023
3 checks passed
@tchalvak tchalvak deleted the feat/recap branch December 29, 2023 22:42
Copy link

cypress bot commented Dec 29, 2023

Passing run #120 ↗︎

0 8 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge pull request #1610 from BitLucid/feat/recap
Project: NinjaWars Functional Testing Commit: ec38e055bb
Status: Passed Duration: 01:36 💡
Started: Dec 29, 2023 10:43 PM Ended: Dec 29, 2023 10:45 PM

Review all test suite changes for PR #1610 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant