Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Render Issue Solved #403

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

NK-Works
Copy link
Contributor

@NK-Works NK-Works commented Nov 6, 2024

Title and Issue number

Title: Refresh Rendering of Pages not Working

Issue No.:

Close #400


Screenshots/Video (mandatory)

Video only possible after deployment.... So can't make it you can first test it once then go with merging


Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
  • I have gone through the contributing.md file before contributing.

Additional context (Mandatory):

Are you contributing under any Open-source programme?

  • I'm a GSSOC-EXT contributor
  • I'm a HACKTOBERFEST contributor

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for bitbox-in ready!

Name Link
🔨 Latest commit 865c57c
🔍 Latest deploy log https://app.netlify.com/sites/bitbox-in/deploys/672cdd41fe18ba0008bffd9f
😎 Deploy Preview https://deploy-preview-403--bitbox-in.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28
Accessibility: 80
Best Practices: 83
SEO: 91
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 6, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Anuj3553
Copy link
Collaborator

Anuj3553 commented Nov 7, 2024

Please give the video of your work.

@NK-Works
Copy link
Contributor Author

NK-Works commented Nov 7, 2024

Here's the video:

Screen.Recording.2024-11-07.101729.mp4

Even after multiple refreshes the page renders.

@Anuj3553 Anuj3553 self-requested a review November 7, 2024 05:29
@Anuj3553 Anuj3553 added gssoc-ext Extended contribution for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level2 Intermediate-level contribution or task hacktoberfest Open-source contribution during October for GSSoC labels Nov 7, 2024
@Anuj3553
Copy link
Collaborator

Anuj3553 commented Nov 7, 2024

Here's the video:

Screen.Recording.2024-11-07.101729.mp4
Even after multiple refreshes the page renders.

Okk first i have to test then after i can merge this PR.

@NK-Works
Copy link
Contributor Author

NK-Works commented Nov 7, 2024

👍

@Anuj3553 Anuj3553 merged commit ab9f26c into Bitbox-Connect:main Nov 7, 2024
4 checks passed
@Anuj3553
Copy link
Collaborator

Anuj3553 commented Nov 7, 2024

Well done @NK-Works

Copy link

github-actions bot commented Nov 7, 2024

🎉🎉 Thank you for your contribution! Your PR #403 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Extended contribution for GSSoC hacktoberfest Open-source contribution during October for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level2 Intermediate-level contribution or task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Refresh Rendering of Pages not Working
2 participants