use gh-issues to update conferences.json #503
Conversation
update issue template to include start and end dates for conference update conferences to use gh-issues instead of manual parsing update conferences template to use grid and new json methods add conferences.json remove envrc
|
TODO:
|
update issue template to include start and end dates for conference update conferences to use gh-issues instead of manual parsing update conferences template to use grid and new json methods add conferences.json
|
You were the last to work on this. would you mind puttins some eyes on this change. |
| from github.Issue import Issue | ||
| from github.PaginatedList import PaginatedList | ||
| import json | ||
| import gh_issues |
There was a problem hiding this comment.
Me looking up the gh_issues library
| ], | ||
| ) | ||
| def tests_validate_issue(check_value, asserted_value): | ||
| """tests the date validator againse yesterday value (fail) and tomorrow value (pass)""" |
There was a problem hiding this comment.
| """tests the date validator againse yesterday value (fail) and tomorrow value (pass)""" | |
| """tests the date validator against yesterday value (fail) and tomorrow value (pass)""" |
| if not (valid_date := getattr(issue, date_to_check, False)): | ||
| return False | ||
| else: | ||
| return __to_conference_date(valid_date) >= datetime.date.today() |
There was a problem hiding this comment.
Something else that I think would make sense to check is if end_date >= start_date. Take this for example:
today_date = 10/05/2024
start_date = 10/15/2024
end_date = 10/10/2024
This scenario will always clear the validate_issue check because the conference end date is after today's date. But it still shouldn't be considered a valid conference since the end date is before the start date. Let me know if I'm overthinking this one or not
There was a problem hiding this comment.
I think maybe you're overthinking this as this validation is purely to filter out the entry from the generated json list.
These conference entries should still be validated by someone on the triage team and if there is an issue in entry, it is the triage members responsibility to detect that.
| "conference_type": "in-person", | ||
| "conference_location": "NWSC International Resource Centre (IREC), Kampala, Uganda", | ||
| "summary": "The conference is a five-day event, 9-13 October. PyconUganda inherit this tradition of an annual event that brings together python enthusiasts, tech audiences and technology business in uganda and around the world.", | ||
| "speaking": null |
There was a problem hiding this comment.
I'm curious, what will the format of the speaking field look like? Would it be a list of json objects?
There was a problem hiding this comment.
Currently it is a string of entries...
I was thinking of a GH-Issue feature that would that would convert a list to a python list.
with events.md being a .md file. It should render properly in the website.
Co-authored-by: Alex Oladele <[email protected]>
|
Well I'm good on these changes (though I don't have write access, so my approval means nothing) |
|
@dragid10 - updated the approval limit for the triage team |
update issue template to include start and end dates for conference
update conferences to use
gh-issuesinstead of manual parsingupdate conferences template to use
gridand new json dataadd conferences.json