Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pagination feature #621

Merged

Conversation

TimOsahenru
Copy link
Contributor

@TimOsahenru TimOsahenru commented Dec 26, 2024

Issue Link 🔗:

Issue: #615

Type of Change

  • Bug fix 🐞
  • New feature/page
  • Documentation update
  • Other

Description 📋

Implemented pagination for the blog page. Had to change blog.md to blog.html. Apparently Jekyll requires the paginated page to be a layout file (.html) and not a Markdown file (.md) for the paginator variable to work.

Checklist ✅

  • Followed the Code of Conduct and Contribution Guide
  • Ran pre-commit run --all
  • All tests pass locally
  • Added tests (if applicable)
  • Documentation updated (if applicable)

Additional Notes & Screenshots

image

Add any additional notes or comments that might be helpful for the reviewers.

@TimOsahenru TimOsahenru marked this pull request as ready for review December 27, 2024 18:08
(
"/",
"/blog",
),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this from our test case as it was causing the test to fail. The homepage no longer includes posts/blogs according to the latest changes and updates.

@kjaymiller kjaymiller merged commit 0ab1338 into BlackPythonDevs:gh-pages Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants