Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Improved swallowing #140

Merged
merged 14 commits into from
Jan 4, 2022
Merged

Improved swallowing #140

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
32a528a
Make swallowing more robust
eylles Nov 9, 2021
f28ee92
Improved swallow filter
eylles Nov 10, 2021
9765637
remove occurences of res var
eylles Nov 15, 2021
6a6e61f
renamed functions and theme vars more descriptive
eylles Nov 16, 2021
5f0d3c4
updated module documentation
eylles Nov 16, 2021
ab5f44e
check functions combined, is_in_table 1 return
eylles Nov 21, 2021
8670856
add old theme vars for compatibility
eylles Nov 28, 2021
455aa82
short swallow logic and robust filter assignment
eylles Dec 17, 2021
2c5f7dd
ignore splash and dialog parents
eylles Dec 17, 2021
3e9c4a1
consistent docs formatting
eylles Dec 17, 2021
54fbe76
convert module to use an async function
eylles Dec 17, 2021
4465035
removed undefined error() function call
eylles Dec 19, 2021
8a87381
deal with corner case: parent exits before client
eylles Dec 27, 2021
ec5cc22
added meself to authors
eylles Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions module/window_swallowing.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,23 @@ local function check_swallow(parent, child)
return res
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the function returns false when window_swallowing_activated is false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what i can tell no, since window_swallowing_activated = false means that the swallowing function will be disconected from all clients.

105 local function start()
106     client.connect_signal("manage", manage_clientspawn)
107     window_swallowing_activated = true
108 end
109
110 local function stop()
111     client.disconnect_signal("manage", manage_clientspawn)
112     window_swallowing_activated = false
113 end
114
115 local function toggle()
116     if window_swallowing_activated then
117         stop()
118     else
119         start()
120     end
121 end

however if you meant the boolean value of swallowing_filter then reffering back to the truth table the output value of this function should only be false when the filter is active and either parent or child is in any of the filtering lists.

Copy link

@Aire-One Aire-One Dec 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I have forgotten the use of this variable and thought it has what the user change to activate the module... My bad.

end

-- async function to get the parent's pid
-- recieves a child process pid and a callback function
-- parent_pid in format "init(1)---ancestorA(pidA)---ancestorB(pidB)...---process(pid)"
function get_parent_pid(child_ppid, callback)
local ppid_cmd = string.format("pstree -A -p -s %s", child_ppid)
awful.spawn.easy_async(ppid_cmd, function(stdout, stderr, reason, exit_code)
-- primitive error checking
if stderr and stderr ~= "" then
callback(stderr)
return
end
local ppid = stdout
callback(nil, ppid)
end)
end


-- the function that will be connected to / disconnected from the spawn client signal
local function manage_clientspawn(c)
-- get the last focused window to check if it is a parent window
Expand All @@ -60,12 +77,12 @@ local function manage_clientspawn(c)
return
end

-- io.popen is normally discouraged. Should probably be changed
-- returns "init(1)---ancestorA(pidA)---ancestorB(pidB)...---process(pid)"
local handle = io.popen("pstree -A -p -s " .. tostring(c.pid))
local parent_pid = handle:read("*a")
handle:close()

get_parent_pid(c.pid, function(err, ppid)
if err then
error(err)
eylles marked this conversation as resolved.
Show resolved Hide resolved
return
end
parent_pid = ppid
if
-- will search for "(parent_client.pid)" inside the parent_pid string
( tostring(parent_pid):find("("..tostring(parent_client.pid)..")") )
Expand All @@ -79,6 +96,7 @@ local function manage_clientspawn(c)
helpers.client.sync(c, parent_client)
helpers.client.turn_off(parent_client)
end
end)
end

-- without the following functions that module would be autoloaded by require("bling")
Expand Down