-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
移植 SettingsControls #771
Merged
Merged
移植 SettingsControls #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a5fadae.
Blinue
commented
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个bug表现非常诡异:附加调试器的时候没有问题,直接运行就会崩溃。能定位到很大程度是运气。
使用 SettingsExpander 中的 ListView
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #769
这个 PR 移植了 Windows Community Toolkit 中的 SettingsCard 和 SettingsExpander 控件以及它们的依赖项IsEqualStateTrigger、IsNullStateTrigger 和 ControlSizeTrigger,删除了旧版 SettingsCard。还有一些 UI 优化。
并非原样移植,移植过程中进行了一些优化、重构和修复,以满足我们自己的需求。
我计划接下来优化 SettingsCard 的布局,使得可以智能切换水平和竖直排列,这将在另一个 PR 中完成。