Improve handling of bitcoind-related connection/timeout issues #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what the actual timeout value should be, used 5 seconds as a placeholder. Thoughts? |
shesek
changed the title
shesek
force-pushed
the
202405-bitcoind-timeout
branch
2 times, most recently
from
bc09e86
to
8c3fc1c
Compare
|
Increased timeout to 10 seconds, removed the commit that added a reconnection limit (forced-pushed) |
philippem
reviewed
May 16, 2024
shesek
force-pushed
the
202405-bitcoind-timeout
branch
from
0579704
to
95a5ef7
Compare
|
squash? |
Configurable via the DAEMON_{CONNECTION,READ,WRITE}_TIMEOUT environment variables.
So that they will be handled by the retry_request_batch() automatic retry mechanism, which only applies to connection-related errors.
shesek
force-pushed
the
202405-bitcoind-timeout
branch
from
95a5ef7
to
2d8ccee
Compare
philippem
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.