Nix improvements #96
Merged
Nix improvements #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammatically improve first compilation by avoiding to recompile rocksdb. It may also improve performance.
users with direnv+nix have the env setup just by entering the dir
in nix they don't work anyway why bother
exe_path continue to look at downloaded_exe_path unless a specific env var is specified
delta1
approved these changes
Aug 13, 2024
|
utack |
philippem
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need some more work to run all the test suite on nix systems but that will need some changes in upstream
electrumdon which a PR is coming