Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to pysony.py #39

Closed
wants to merge 3 commits into from
Closed

Changes to pysony.py #39

wants to merge 3 commits into from

Conversation

qwe2tz
Copy link

@qwe2tz qwe2tz commented Sep 26, 2017

  • Pep8 compliant
  • Added support for multiple versions of Sony SDK APIs
  • Maintaining legacy support

@mungewell
Copy link
Contributor

Hi,
can you please explain the benefit of having the 'version' string included in the command. I think this is to allow camera to understand the scope of what to return (ie. getEvent has multiple versions). I also note that some commands (ie. deleteContent) do not have a "version 1.0" equvilant.

Seems like a good idea, but can you break the patch down so that each part only has one purpose (clearer on what it does and enables cherry picking).

@mungewell
Copy link
Contributor

Changes to 'class ControlPoint()' break the search technique used in the examples. Assumes a particular IP (rather than searching) and requires an additional 'search.connect()' call.

Fixed IP should only be used if end user sets one, I have cameras which show up on either 'http://10.0.0.1:10000' (QX10) or 'http://192.168.122.1:8080' (HX60).

For a better search technique checkout the patch on:
#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants