Skip to content

Commit

Permalink
Deprecate Python 3.10 and numpy 1.24. Fixes #315.
Browse files Browse the repository at this point in the history
  • Loading branch information
FrancescAlted committed Nov 4, 2024
1 parent 3ad3ad0 commit f94349f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 28 deletions.
26 changes: 2 additions & 24 deletions .github/workflows/cibuildwheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:
arch: [x86_64, aarch64]
# Just build for x86_64 for now (Mac arm64 is already covered by cibuildwheel)
# arch: [x86_64]
cibw_build: ["cp3{10,11,12}-*"]
p_ver: ["3.10-3.12"]
cibw_build: ["cp3{11,12,13}-*"]
p_ver: ["3.11-3.13"]
exclude:
- os: windows-latest
arch: aarch64
Expand Down Expand Up @@ -69,28 +69,6 @@ jobs:

- name: Build wheels
uses: pypa/[email protected]
# TODO: fix this when releasing Python 3.13 wheels
# env:
# # Python 3.13 fails with:
# # from blosc2.schunk import SChunk
# # ../venv/lib/python3.13/site-packages/blosc2/schunk.py:1346: in <module>
# # @_inherit_doc_parameter(blosc2.Storage, "initial_mapping_size:", {r"r\+ w\+, or c": "r+ or c"})
# # ../venv/lib/python3.13/site-packages/blosc2/helpers.py:15: in wrapper
# # match is not None
# # E AssertionError: Parameter initial_mapping_size: not found in the docstring of Storage
# # I don't see obvious way to fix this, so we skip it for now
# CIBW_BEFORE_TEST: |
# if [ "$RUNNER_OS" == "Windows" ]; then
# if [ "%PYTHON_VERSION%" == "3.13" ]; then
# echo "Skipping tests for Python 3.13 on Windows"
# exit 0
# fi
# else
# if [ "${{ matrix.p_ver }}" == "3.13" ]; then
# echo "Skipping tests for Python 3.13 on Unix-like systems"
# exit 0
# fi
# fi

- name: Upload wheels
uses: actions/upload-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ project(python-blosc2)
# Specifying Python version below is tricky, but if you don't specify the minimum version here,
# it would not consider python3 when looking for the executable. This is problematic since Fedora
# does not include a python symbolic link to python3.
# find_package(Python 3.10 COMPONENTS Interpreter NumPy Development.Module REQUIRED)
# find_package(Python 3.12 COMPONENTS Interpreter NumPy Development.Module REQUIRED)
# IMO, this would need to be solved in Fedora, so we can just use the following line:
find_package(Python COMPONENTS Interpreter NumPy Development.Module REQUIRED)

Expand Down
5 changes: 2 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,14 @@ classifiers = [
"Operating System :: Microsoft :: Windows",
"Operating System :: Unix",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
]
requires-python = ">=3.10"
requires-python = ">=3.11"
# Follow guidelines from https://scientific-python.org/specs/spec-0000/
dependencies = [
"numpy>=1.23.0",
"numpy>=1.25.0",
"ndindex",
"msgpack",
"numexpr",
Expand Down

0 comments on commit f94349f

Please sign in to comment.