Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v3 binlog support #141

Merged
merged 41 commits into from
Aug 21, 2023
Merged

Add v3 binlog support #141

merged 41 commits into from
Aug 21, 2023

Conversation

sindrehan
Copy link
Member

@sindrehan sindrehan commented Aug 10, 2023

This PR add support for the new binary log format introduced with Blunux v3.0.

In short:

Breaking changes:

  • Old Logs class has been renamed to LegacyLogs
  • Old LogFile class has been renamed to LegacyLogFile

@sindrehan sindrehan added documentation Improvements or additions to documentation enhancement New feature or request http Issues related to HTTP end-points on the drone. labels Aug 10, 2023
@sindrehan sindrehan added this to the v2.0 milestone Aug 10, 2023
@sindrehan sindrehan self-assigned this Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #141 (28c6ef7) into master (f0abd45) will decrease coverage by 1.81%.
The diff coverage is 62.67%.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   73.58%   71.78%   -1.81%     
==========================================
  Files          10       10              
  Lines         969     1095     +126     
==========================================
+ Hits          713      786      +73     
- Misses        256      309      +53     
Flag Coverage Δ
macos-latest_3.10 71.78% <62.67%> (-1.81%) ⬇️
macos-latest_3.11 71.78% <62.67%> (-1.81%) ⬇️
macos-latest_3.8 71.78% <62.67%> (-1.81%) ⬇️
macos-latest_3.9 71.78% <62.67%> (-1.81%) ⬇️
ubuntu-latest_3.10 71.78% <62.67%> (-1.81%) ⬇️
ubuntu-latest_3.11 71.78% <62.67%> (-1.81%) ⬇️
ubuntu-latest_3.8 71.78% <62.67%> (-1.81%) ⬇️
ubuntu-latest_3.9 71.78% <62.67%> (-1.81%) ⬇️
windows-latest_3.10 71.75% <62.67%> (-1.80%) ⬇️
windows-latest_3.11 71.75% <62.67%> (-1.80%) ⬇️
windows-latest_3.8 71.75% <62.67%> (-1.80%) ⬇️
windows-latest_3.9 71.75% <62.67%> (-1.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
blueye/sdk/logs.py 71.84% <62.14%> (-21.99%) ⬇️
blueye/sdk/drone.py 75.00% <100.00%> (+0.12%) ⬆️

tests/test_logs.py Dismissed Show dismissed Hide dismissed
tests/test_logs.py Dismissed Show dismissed Hide dismissed
@sindrehan sindrehan marked this pull request as ready for review August 14, 2023 11:47
@sindrehan sindrehan merged commit fa1a7a4 into master Aug 21, 2023
16 of 18 checks passed
@sindrehan sindrehan deleted the add-v3-binlog-support branch August 21, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request http Issues related to HTTP end-points on the drone.
Projects
None yet
2 participants