Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gripper interface #148

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Add gripper interface #148

merged 7 commits into from
Sep 26, 2023

Conversation

sindrehan
Copy link
Member

@sindrehan sindrehan commented Sep 21, 2023

This PR adds support for interacting with a gripper.

Fixes #129

@sindrehan sindrehan added the enhancement New feature or request label Sep 21, 2023
@sindrehan sindrehan added this to the v2.0 milestone Sep 21, 2023
@sindrehan sindrehan self-assigned this Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (bc26855) 73.17% compared to head (8b5fd79) 72.26%.

❗ Current head 8b5fd79 differs from pull request most recent head 20ec874. Consider uploading reports for the commit 20ec874 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   73.17%   72.26%   -0.91%     
==========================================
  Files          11       11              
  Lines        1178     1208      +30     
==========================================
+ Hits          862      873      +11     
- Misses        316      335      +19     
Flag Coverage Δ
macos-latest_3.10 72.26% <38.70%> (-0.91%) ⬇️
macos-latest_3.11 72.26% <38.70%> (-0.91%) ⬇️
macos-latest_3.8 72.24% <38.70%> (-0.91%) ⬇️
macos-latest_3.9 72.24% <38.70%> (-0.91%) ⬇️
ubuntu-latest_3.10 72.26% <38.70%> (-0.91%) ⬇️
ubuntu-latest_3.11 72.26% <38.70%> (-0.91%) ⬇️
ubuntu-latest_3.8 72.24% <38.70%> (-0.91%) ⬇️
ubuntu-latest_3.9 72.24% <38.70%> (-0.91%) ⬇️
windows-latest_3.10 72.24% <38.70%> (-0.91%) ⬇️
windows-latest_3.11 72.24% <38.70%> (-0.91%) ⬇️
windows-latest_3.8 72.22% <38.70%> (-0.91%) ⬇️
windows-latest_3.9 72.22% <38.70%> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
blueye/sdk/connection.py 51.42% <33.33%> (-0.27%) ⬇️
blueye/sdk/drone.py 77.82% <33.33%> (-0.72%) ⬇️
blueye/sdk/guestport.py 67.69% <40.00%> (-17.31%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sindrehan sindrehan marked this pull request as ready for review September 26, 2023 10:08
blueye/sdk/guestport.py Outdated Show resolved Hide resolved
@sindrehan sindrehan merged commit ac2fff9 into master Sep 26, 2023
15 checks passed
@sindrehan sindrehan deleted the add-gripper-interface branch September 26, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gripper interface
3 participants