Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observer mode #168

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Add observer mode #168

merged 1 commit into from
Sep 4, 2024

Conversation

sindrehan
Copy link
Member

@sindrehan sindrehan commented Sep 3, 2024

This PR allows the SDK to signal to the drone that it does not want to be promoted to a client in control.

Fixes #160, Fixes #167

@sindrehan sindrehan added the enhancement New feature or request label Sep 3, 2024
@sindrehan sindrehan self-assigned this Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.77%. Comparing base (f185994) to head (d5ecc78).

Files with missing lines Patch % Lines
blueye/sdk/connection.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   73.83%   73.77%   -0.06%     
==========================================
  Files          11       11              
  Lines        1265     1266       +1     
==========================================
  Hits          934      934              
- Misses        331      332       +1     
Flag Coverage Δ
macos-latest_3.10 73.77% <75.00%> (-0.06%) ⬇️
macos-latest_3.11 73.77% <75.00%> (-0.06%) ⬇️
macos-latest_3.12 73.77% <75.00%> (-0.06%) ⬇️
macos-latest_3.9 73.75% <75.00%> (-0.06%) ⬇️
ubuntu-latest_3.10 73.77% <75.00%> (-0.06%) ⬇️
ubuntu-latest_3.11 73.77% <75.00%> (-0.06%) ⬇️
ubuntu-latest_3.12 73.77% <75.00%> (-0.06%) ⬇️
ubuntu-latest_3.9 73.75% <75.00%> (-0.06%) ⬇️
windows-latest_3.10 73.75% <75.00%> (-0.06%) ⬇️
windows-latest_3.11 73.75% <75.00%> (-0.06%) ⬇️
windows-latest_3.12 73.75% <75.00%> (-0.06%) ⬇️
windows-latest_3.9 73.73% <75.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@follesoe follesoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

@sindrehan sindrehan enabled auto-merge (squash) September 4, 2024 06:59
@sindrehan sindrehan merged commit fbaf81c into master Sep 4, 2024
18 checks passed
@sindrehan sindrehan deleted the add-observer-mode branch September 4, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to connect the Drone as an observer Add observer mode
2 participants