Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-usr: provide sepeate class for checkout usage #249

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

rhubert
Copy link
Contributor

@rhubert rhubert commented Feb 7, 2025

65cedc9 makes python usabe in checkoutScripts. This produces different checkoutVariants for recipes where the python part is only needed for one multiPackage but not for another:

checkoutSCM:
 ...

multiPackage:
    foo:

    python:
        inherit: [python3-usr]

Revert 65cedc9 and add a separate python3-usr-checkout class to avoid this.

Copy link
Member

@jkloetzke jkloetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate that we have to duplicate the code but I don't see a better option either...

65cedc9 makes python usabe in checkoutScripts. This produces different
checkoutVariants for recipes where the python part is only needed for
one multiPackage but not for another:

checkoutSCM:
 ...

multiPackage:
    foo:

    python:
        inherit: [python3-usr]

Revert 65cedc9 and add a separate python3-usr-checkout class to avoid
this.
@jkloetzke jkloetzke merged commit c13893f into BobBuildTool:master Feb 23, 2025
2 checks passed
@jkloetzke
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants