Skip to content

Commit

Permalink
Improve logging for missing parameters in dvc.yaml during get-config
Browse files Browse the repository at this point in the history
  • Loading branch information
grst committed Nov 18, 2024
1 parent 6b2bfe9 commit d24bde0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning][].
- Remove vendored `hiyapyco` code since required changes were released upstream in v0.7.0 ([#45](https://github.com/Boehringer-Ingelheim/dso/pull/45)).
- `None` values in `params.in.yaml` can now be used to override anything, e.g. to disable watermarking only in a specific stage ([#45](https://github.com/Boehringer-Ingelheim/dso/pull/45)).
- Improve logging for "missing path" warning during `compile-config` ([#59](https://github.com/Boehringer-Ingelheim/dso/pull/59)).
- Improve logging for missing parameters in `dvc.yaml` during `get-config` ([#59](https://github.com/Boehringer-Ingelheim/dso/pull/59)).

## v0.9.0

Expand Down
4 changes: 2 additions & 2 deletions src/dso/get_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,6 @@ def cli(stage, all, skip_compile):
out_config = get_config(stage, all=all, skip_compile=skip_compile)
yaml = YAML()
yaml.dump(out_config, sys.stdout)
except KeyError:
log.error("dvc.yaml defines parameter that is not in params.yaml")
except KeyError as e:
log.error(f"dvc.yaml defines parameter {e} that is not in params.yaml")
sys.exit(1)

0 comments on commit d24bde0

Please sign in to comment.