Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rc/1.1.0 #12

Merged
merged 34 commits into from
Dec 16, 2024
Merged

Rc/1.1.0 #12

merged 34 commits into from
Dec 16, 2024

Conversation

iglauss
Copy link
Contributor

@iglauss iglauss commented Dec 11, 2024 •
edited by mattkorb
Loading

Critical checks

  • Is the version number correct?

    • DESCRIPTION file

    • NEWS.md

  • Does the build pass?

Documentation

Does it include the following sections?

  • Module introduction with features

    • (O) Screenshots

  • Installation details

  • Explanation of function arguments

  • Data specifications and requirements

  • Different possible visualizations

  • Are the changes/new features included in NEWS.md?

  • (O) Screenshots

  • (O) Explanation of input menus

  • (O) Short articles on building the app, compatibility with other modules, known bugs,...

QC Report

  • Does it include a QC Report with positive outcome?

  • Are the new features reflected accordingly in the specs?

API conventions

  • Follows API convention

ml-ebs-ext and others added 30 commits October 11, 2024 17:59
@ml-ebs-ext
Formalize interface with papo.
374342a
@ml-ebs-ext
Isolate common portions of papo interface test.
94f97bf
@ml-ebs-ext
Remove duplicates.
4e25d25
@ml-ebs-ext
Simplify papo test harness.
79bf4a3
@ml-ebs-ext
Tweaks suggested by PR.
f13c571
@ml-ebs-ext
Merge pull request #8 from Boehringer-Ingelheim/formal_papo_iface
d4a40a2 
Formalize interface with papo.
@iglauss
multiple drugs per patient - POC
677823f
@mattkorb
Display multiple drugs per subject POC
8b2fcea
@iglauss
Fix start/equal symbols and shape legend
e06dd00
@mattkorb
Add size to geom_point
06985b4
@iglauss
add color_palette argument
a25619e
@iglauss
Refine color_palette checks
d35a9b7
@iglauss
Update mod call to enable users to specify trt_var
885360b
@iglauss
fix unit tests
59482e6
@iglauss
Add tests for customizable colors
d9ce092
@iglauss
Add test for check_valid_color() function
def9193
@mattkorb
Fix tooltip
8a409ff
@iglauss
update switch2 to switch2mod
f2af6a5
@iglauss
update mock apps
a6a192e
@iglauss
Update NEWS file.
7719e81
@iglauss
fix legend label issue when drug_admin = NULL; fix error when only ti…
c19fe28 
…mepoints are specified
@iglauss
tests: update snapshot and get rid of warnings
69e79eb
@iglauss
solve commented_code_linter findings
d3a8511
@iglauss
update documentation
88b7696
@iglauss
update DESCRIPTION file to contain latest dv.manager version
1dbb39c
@iglauss
fix failing tests
26f42da
@iglauss
failing tests: increase wait_for_idle() timeout time
75cec1a
@iglauss
update large test app to fix failing test
1f3a7d6
@iglauss
update papo jumping test
249f8b8
@iglauss
Merge pull request #11 from Boehringer-Ingelheim/multiple-drugs-handling
dfbd199 
Multiple drugs handling, customizable color palette, and small fixes
@iglauss iglauss requested a review from a team as a code owner December 11, 2024 13:27
@iglauss iglauss requested a review from mattkorb December 11, 2024 13:41
mattkorb
mattkorb reviewed Dec 13, 2024
View reviewed changes
R/data_prep.R Outdated Show resolved Hide resolved
@iglauss iglauss merged commit 81e3fc0 into main Dec 16, 2024
12 checks passed
@iglauss iglauss deleted the rc/1.1.0 branch December 16, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkorb mattkorb mattkorb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iglauss @mattkorb @ml-ebs-ext