-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #11 from Boehringer-Ingelheim/early_error_feedback
Remove support for dispatchers; add early error feedback; tweak test to make it a bit more solid.
- dev
- (#16, #11)
- jumping_feature1
- (#11)
Showing
18 changed files
with
1,160 additions
and
150 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,8 +11,6 @@ on: | |
branches: | ||
- main | ||
push: | ||
branches: | ||
- main | ||
workflow_dispatch: | ||
|
||
jobs: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
linters <- lintr::default_linters # -[ diff with dv.templates 3ca8d7a10cfc7ad2307644dcac603e1f1f0feb72]- | ||
linters <- lintr::modify_defaults( | ||
linters | ||
, line_length_linter = NULL # we see how long lines are when we write them | ||
, indentation_linter = NULL | ||
, trailing_whitespace_linter = NULL | ||
, cyclocomp_linter = NULL # prevents trivial amount of nesting and long but straightforward functions | ||
, object_name_linter = NULL # we have reasons to capitalize. nobody in our team CamelCase. shiny does | ||
, object_length_linter = NULL # we don't type long var names just because | ||
, pipe_continuation_linter = NULL # wickham being overly prescriptive | ||
, trailing_blank_lines_linter = NULL # natural extension of trailing_whitespace_linter, present on the template | ||
) | ||
|
||
if(identical(Sys.getenv('CI'), "true")){ | ||
linters <- lintr::modify_defaults( | ||
linters | ||
, object_usage_linter = NULL # R lacks var declarations; it's easy to assign to the wrong variable by mistake | ||
) # We only disable this lint rule on github because it fails there because | ||
} # of a long-standing lintr bug | ||
|
||
exclusions <- list("tests") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.