-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jumping feature #12
base: dev
Are you sure you want to change the base?
Jumping feature #12
Changes from all commits
6a619e1
e13a17e
e5377dc
1cee94a
db4f0fe
69f254a
6cd7240
d39cf51
c22bd5a
21178e1
aca095f
da9e017
9ddfacf
28d5e42
17d78c7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,6 @@ | |
^docs$ | ||
^README\.html$ | ||
^LICENSE$ | ||
^\.github | ||
^\.github | ||
^doc$ | ||
^Meta$ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
Package: dv.listings | ||
Type: Package | ||
Title: Data listings module | ||
Version: 4.0.1 | ||
Version: 4.0.2 | ||
Authors@R: | ||
c( | ||
person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")), | ||
|
@@ -31,6 +31,7 @@ Imports: | |
dplyr (>= 1.0.5), | ||
DT (>= 0.18), | ||
dv.manager (>= 2.0.0-17), | ||
gm-ebs-ext marked this conversation as resolved.
Show resolved
Hide resolved
|
||
dv.papo (>= 2.0.1), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we really need this dependency? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just added a comment related to this suggesting the current davinci strategy for checking communication with papo. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This hard dependency is only there for testing the communication with papo, I believe. The current way of testing communication with papo is to mock it, as we do on That snippet of code is repeated across packages and I have a fix in the works to ensure that the repeat code is not an issue, so it should be OK for you to use that same strategy. |
||
htmlwidgets (>= 1.6.2), | ||
magrittr (>= 2.0.3), | ||
openxlsx (>= 4.2.5.2), | ||
|
@@ -41,7 +42,7 @@ Imports: | |
shinyjs (>= 2.1.0), | ||
shinyWidgets (>= 0.8.0), | ||
tibble (>= 3.2.1) | ||
RoxygenNote: 7.3.1 | ||
RoxygenNote: 7.3.2 | ||
Roxygen: list(markdown = TRUE) | ||
Remotes: boehringer-ingelheim/dv.manager@main | ||
VignetteBuilder: knitr |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
# dv.listings 4.0.2 | ||
|
||
- add jumping feature | ||
|
||
# dv.listings 4.0.1 | ||
|
||
The module allows now to | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of recent changes to our release process when merging to
dev
we should probably use a fourth component to the semantic versioning:https://r-pkgs.org/lifecycle.html#sec-lifecycle-version-number-tidyverse
Here's an example in
dv.manager
:https://github.com/Boehringer-Ingelheim/dv.manager/blob/dev/DESCRIPTION#L4