Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAA-165 - Updated README.md and add PUBLISHING.md with new github auth #5

Merged
merged 2 commits into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,16 @@ forking the repository and sending a pull request.

When submitting code follow the existing conventions and code style. Ensure that your code changes build and unit tests pass.

Before your code can be accepted into the project you must also sign the
[Individual Contributor License Agreement (CLA)][1].
### Creating Personal Access Token (PAT)
To publish this library to github, you need to create a Personal Access Token (PAT) on GitHub. Please follow the instructions below:
- On github, create a Token (classic), for information on this please see https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token
- Grant the following permissions to your PAT: **read:packages**, **write:packages**, and **repo**
- Save the token in a safe place, i.e. 1Password.
- Finally, authorize BottleRocketStudios to use your PAT.


[1]: https://brcontributor.parseapp.com/
### Specify user name and token as Shell Environment Variables
- In your shell file like .bash_profile, .zshrc, OR .zlogin, add these two statements:
```
export REPO_READ_WRITE_USER=<<Your Github Username or Email Address>>
export REPO_READ_WRITE_TOKEN=<<Your PAT>>
```
3 changes: 1 addition & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ kt-lint-gradle = "11.6.1"
navigation-compose = "2.7.6"
precompose = "1.5.10"


compile-sdk = "34"
min-sdk = "24"
launchpad-compose = "0.0.2"
launchpad-compose = "0.0.3"

[libraries]
androidx-navigation-compose = { module = "androidx.navigation:navigation-compose", version.ref = "navigation-compose" }
Expand Down
4 changes: 2 additions & 2 deletions kmp-launchpad-compose/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ publishing {
name = "GitHubPackages"
url = uri("https://maven.pkg.github.com/BottleRocketStudios/KMP-LaunchPad-Compose")
credentials {
username = System.getenv("GITHUB_ACTOR") ?: System.getenv("LOCAL_GITHUB_USERNAME")
password = System.getenv("GITHUB_TOKEN") ?: System.getenv("LOCAL_GITHUB_TOKEN")
username = System.getenv("REPO_READ_WRITE_USER")
password = System.getenv("REPO_READ_WRITE_TOKEN")
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ fun ComponentActivity.createDevicePostureFlow() = WindowInfoTracker.getOrCreate(
.stateIn(
scope = lifecycleScope,
started = SharingStarted.Eagerly,
initialValue = DevicePosture.NormalPosture
initialValue = DevicePosture.NormalPosture,
)

/**
Expand Down