-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implement pure-Python ICA with mixture modeling #51
Conversation
) | ||
os.system(math_command) | ||
if not mask: | ||
mask = masking.compute_epi_mask(in_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More aggressive masking seems to be necessary. I noticed that the ICA components were showing up outside the brain with the old method.
As discussed with @CesarCaballeroGaudes yesterday, the mixture modeling is not necessary but it helps with the accuracy. The ICA-AROMA paper states:
So, we could try running the workflow without the mixture modeling first and see if the results look good. If we see the mixture modeling is critical for accuracy, we can open a new PR with it. |
To be honest, I'm not confident that either the features or the classifier in AROMA are robust enough to handle inputs that don't exactly match the original method. From a conceptual standpoint, unthresholded maps may be fine, but from a practical one, I'm not so sure. |
I have ME-ICA/aroma#22 open now, so I'm going to close this. |
Closes #2.
TODO:
nipy
's GGM.computefeats2
working).Changes proposed in this pull request:
nipy
for mixture modeling.tedana
for PCA + ICA.