feat: add support for arrays #65
Open
+580
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIGMazer
requested changes
Jan 14, 2025
Comment on lines
2049
to
+2061
| case NODE_OPERATION: | ||
| case NODE_UNARY_OPERATION: | ||
| case NODE_INT: | ||
| case NODE_ARRAY_ACCESS: | ||
| if (node->data.array.name && node->data.array.index) | ||
| { | ||
| int length = node->data.array.index->data.ivalue; | ||
| if (!set_array_variable(node->data.array.name, length, node->modifiers, node->var_type)) | ||
| { | ||
| yyerror("Failed to create array"); | ||
| } | ||
| } | ||
| break; |
There was a problem hiding this comment.
this is what makes the test fail it reference to null when the node type is unary.
you can move this
case NODE_OPERATION:
case NODE_UNARY_OPERATION:
case NODE_INT:after the NODE_ARRAY_ACCESS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
rizz,smol,cap,yap,chadandgigachadarrays.Type of Change
Checklist