Skip to content

Commit

Permalink
[patch] use version numbers in websdk local build (#1086)
Browse files Browse the repository at this point in the history
# Pull Request Template

## Description

I put these to 0.0.0 because i thought it would make it more clear that
these come from elsewhere. (we fill these in with the actual gha version
when we release). However, some of our apis check the values that we
send here. So, having 0.0.0 was breaking some journeys. I put it to
2.85.1. It wont need to be updated unless we make another check on the
backend that we want to test


Fixes # (issue)

## Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration

- [ ] Unit test
- [ ] Integration test

## JS Budget Check

Please mention the size in kb before abd after this PR

| Files            | Before      | After       | 
| -----------      | ----------- | ----------- |
| dist/build.js.   |             |             |
| dist/build.min.js|             |             |

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
- [ ] I have checked my code and corrected any misspellings

## Mentions: 
List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.
  • Loading branch information
bredmond5 authored Nov 7, 2024
1 parent 5459f83 commit 15c30fa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/0_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ var DEFAULT_API_ENDPOINT = 'https://api2.branch.io';
config.app_service_endpoint = 'https://app.link';
config.link_service_endpoint = 'https://bnc.lt';
config.api_endpoint = DEFAULT_API_ENDPOINT;
config.version = '0.0.0';
config.version = '2.85.1'; // will get overwritten by gha on actual deploy
2 changes: 1 addition & 1 deletion test/web-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ goog.provide('config');
config.app_service_endpoint = 'https://app.link';
config.link_service_endpoint = 'https://bnc.lt';
config.api_endpoint = 'https://api.branch.io';
config.version = '0.0.0';
config.version = '2.85.1'; // will get overwritten by gha on actual deploy

0 comments on commit 15c30fa

Please sign in to comment.