Skip to content

Commit

Permalink
[other] a couple more deploy cleanups (#1089)
Browse files Browse the repository at this point in the history
# Pull Request Template

## Description

Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.


Fixes # (issue)

## Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration

- [ ] Unit test
- [ ] Integration test

## JS Budget Check

Please mention the size in kb before abd after this PR

| Files            | Before      | After       | 
| -----------      | ----------- | ----------- |
| dist/build.js.   |             |             |
| dist/build.min.js|             |             |

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
- [ ] I have checked my code and corrected any misspellings

## Mentions: 
List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.
  • Loading branch information
bredmond5 authored Nov 11, 2024
1 parent 441102e commit acba1f9
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/workflows/deploy-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ jobs:
with:
node-version: ${{ env.NODE_VERSION }}

# Do this before npm configure because it writes the package.json version
- name: Write version to files
run: |
./deployment/write-versions.sh ${{ steps.next-version.outputs.result }}
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ All notable changes to the Branch Web SDK will be documented here.
The Branch Web SDK adheres to [Semantic Versioning](http://semver.org/).

## [VERSION] - unreleased
## [2.85.2] - 2024-11-11
- Updates release process
## [2.85.1] - 2024-11-04
- Updates qr image download to avoid errors
## [2.85.0] - 2024-04-10
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ all: dist/build.min.js dist/build.js test/branch-deps.js test/integration-test.h
clean:
rm -f dist/** docs/web/3_branch_web.md test/branch-deps.js dist/build.min.js.gz test/integration-test.html
release: clean all dist/build.min.js.gz
@echo "released"

test/branch-deps.js: $(SOURCES)
npx closure-make-deps \
Expand Down
2 changes: 1 addition & 1 deletion deployment/release-s3.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ make release
aws s3 cp example.html s3://branch-builds/example.html
aws s3 cp example.html s3://branch-cdn/example.html

aws s3 cp --content-type="text/javascript" --content-encoding="gzip" dist/build.js s3://branch-cdn/branch-latest.js --cache-control "max-age=300"
aws s3 cp --content-type="text/javascript" --content-encoding="gzip" dist/build.min.js.gz s3://branch-cdn/branch-$VERSION.min.js --cache-control "max-age=300"
aws s3 cp --content-type="text/javascript" --content-encoding="gzip" dist/build.min.js.gz s3://branch-cdn/branch-latest.min.js --cache-control "max-age=300"

echo -en "Invalidating cloudfront distribution...\n"
aws configure set preview.cloudfront true
aws cloudfront create-invalidation --distribution-id E10P37NG0GMER --paths /branch-latest.min.js


echo "Post-release sanity checks."
read -p "Can you visit https://cdn.branch.io/branch-$VERSION.min.js ?" -n 1 -r
echo
Expand Down
3 changes: 2 additions & 1 deletion examples/example.template.html
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,8 @@ <h4>QR Code</h4>
"background_color": "#FFFFFF",
"margin": 5,
"width": 1000,
"image_format": "png"
"image_format": "png",
"center_logo_url": "https://branch-assets.s3.us-west-1.amazonaws.com/branch-badge-dark.svg",
};
var qrCodeParams = {
tags: [ 'tag1', 'tag2' ],
Expand Down
3 changes: 2 additions & 1 deletion src/0_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ var DEFAULT_API_ENDPOINT = 'https://api2.branch.io';
config.app_service_endpoint = 'https://app.link';
config.link_service_endpoint = 'https://bnc.lt';
config.api_endpoint = DEFAULT_API_ENDPOINT;
config.version = '2.85.1'; // will get overwritten by gha on actual deploy
// will get overwritten by gha on actual deploy
config.version = '2.85.2';
3 changes: 2 additions & 1 deletion test/web-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ goog.provide('config');
config.app_service_endpoint = 'https://app.link';
config.link_service_endpoint = 'https://bnc.lt';
config.api_endpoint = 'https://api.branch.io';
config.version = '2.85.1'; // will get overwritten by gha on actual deploy
// will get overwritten by gha on actual deploy
config.version = '2.85.2';

0 comments on commit acba1f9

Please sign in to comment.