Skip to content

Commit

Permalink
[minor] Have Screen Speak/screen readers on mobile read Journey befor…
Browse files Browse the repository at this point in the history
…e other page content. (#1088)

# Pull Request Template

## Description

For mobile, changed appendChild to prepend so the journey is at the top
of the HTML and is read first by screen readers.

Fixes # (issue)
[ENGMT-1629](https://branch.atlassian.net/browse/ENGMT-1629)

## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration

- [ ] Unit test
- [ ] Integration test
- [ ] Manual testing. Journey's unit tests are commented out (have been
for years it looks like?). Manual testing videos are visible in the JIRA
ticket.

## JS Budget Check

Please mention the size in kb before abd after this PR

| Files            | Before      | After       | 
| -----------      | ----------- | ----------- |
| dist/build.js.   |      166KB       |    166KB         |
| dist/build.min.js|      77KB       |      77KB       |

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [] I have commented my code, particularly in hard-to-understand areas
- [] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
- [x] I have checked my code and corrected any misspellings

## Mentions: 
List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.


[ENGMT-1629]:
https://branch.atlassian.net/browse/ENGMT-1629?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
  • Loading branch information
adamerickson-branch authored Nov 12, 2024
1 parent 9043225 commit ef478c7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ All notable changes to the Branch Web SDK will be documented here.
The Branch Web SDK adheres to [Semantic Versioning](http://semver.org/).

## [VERSION] - unreleased
## [2.86.0] - 2024-11-12
- Switched from appending to prepending journey content on mobile devices so screen readers read the journey first before the underlying page.
## [2.85.4] - 2024-11-11
- updates release process
## [2.85.2] - 2024-11-11
Expand Down
2 changes: 1 addition & 1 deletion src/branch_view.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function renderHtmlBlob(parent, html, hasApp, iframeLoadedCallback) {
}
else
{
document.body.appendChild(iframe);
document.body.prepend(iframe);
}
return iframe;
};
Expand Down

0 comments on commit ef478c7

Please sign in to comment.